Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355399 )
Change subject: Fix incomplete Language::getDatePreferences() documentation
......................................................................
Fix incomplete Language::getDatePreferences() documentation
Look at languages/messages/MessagesEo.php for one of about a dozen real
world examples where this is set to false. All code calling
getDatePreferences checks if it got a truthy value first before using
it.
Change-Id: I4ef5c8be618d41039297325c9dd4cf554ea14559
---
M languages/Language.php
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/99/355399/1
diff --git a/languages/Language.php b/languages/Language.php
index 14e6f5c..fb45cf7 100644
--- a/languages/Language.php
+++ b/languages/Language.php
@@ -725,7 +725,7 @@
}
/**
- * @return array
+ * @return string[]|bool List of date format preference keys, or false
if disabled.
*/
public function getDatePreferences() {
return self::$dataCache->getItem( $this->mCode,
'datePreferences' );
--
To view, visit https://gerrit.wikimedia.org/r/355399
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4ef5c8be618d41039297325c9dd4cf554ea14559
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
