Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355441 )
Change subject: Fix styles queue violation for "ext.wikihiero.Special" ...................................................................... Fix styles queue violation for "ext.wikihiero.Special" The same module is explicitly being loaded twice, once just the styles, and again with the JS/messages/dependencies as well. This is wasteful and also unsupported. Move the two style rules to the main stylesheet and load the proper styles module it belongs to instead. Bug: T92459 Change-Id: I012b4d9bff5bd0379f8b9eb663d5b5dbf71f1885 --- M SpecialHieroglyphs.php M extension.json D modules/ext.wikihiero.Special.css M modules/ext.wikihiero.css 4 files changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/wikihiero refs/changes/41/355441/1 diff --git a/SpecialHieroglyphs.php b/SpecialHieroglyphs.php index 9cd1971..43fdc4b 100644 --- a/SpecialHieroglyphs.php +++ b/SpecialHieroglyphs.php @@ -50,7 +50,7 @@ $this->setHeaders(); $out = $this->getContext()->getOutput(); $out->addModules( 'ext.wikihiero.Special' ); - $out->addModuleStyles( 'ext.wikihiero.Special' ); // apply CSS during slow load + $out->addModuleStyles( 'ext.wikihiero' ); // apply CSS during slow load $out->addWikiMsg( 'wikihiero-special-page-text', wfMessage( 'wikihiero-help-link' )->text() ); $out->addHTML( '<div id="hiero-result">' ); diff --git a/extension.json b/extension.json index 509e4a8..b9f2b17 100644 --- a/extension.json +++ b/extension.json @@ -46,7 +46,6 @@ "ext.wikihiero.Special": { "position": "top", "scripts": "ext.wikihiero.Special.js", - "styles": "ext.wikihiero.Special.css", "dependencies": [ "jquery.spinner" ], @@ -82,4 +81,4 @@ "ext.wikihiero.visualEditor" ], "manifest_version": 1 -} \ No newline at end of file +} diff --git a/modules/ext.wikihiero.Special.css b/modules/ext.wikihiero.Special.css deleted file mode 100644 index 9f48f52..0000000 --- a/modules/ext.wikihiero.Special.css +++ /dev/null @@ -1,10 +0,0 @@ -.mw-hiero-list { - overflow: auto; - height: 400px; - margin-top: 1em; - border: 1px solid #c0c0c0; -} - -.mw-hiero-toc { - text-align: center; -} diff --git a/modules/ext.wikihiero.css b/modules/ext.wikihiero.css index b3a3c37..f91caf3 100644 --- a/modules/ext.wikihiero.css +++ b/modules/ext.wikihiero.css @@ -26,3 +26,14 @@ filter: FlipH; -ms-filter: 'FlipH'; } + +.mw-hiero-list { + overflow: auto; + height: 400px; + margin-top: 1em; + border: 1px solid #c0c0c0; +} + +.mw-hiero-toc { + text-align: center; +} -- To view, visit https://gerrit.wikimedia.org/r/355441 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I012b4d9bff5bd0379f8b9eb663d5b5dbf71f1885 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/wikihiero Gerrit-Branch: wmf/1.30.0-wmf.2 Gerrit-Owner: Krinkle <krinklem...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits