Mvolz has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355600 )

Change subject: Update tests for translators update I6e901585b
......................................................................

Update tests for translators update I6e901585b

* Fix test which was erroneously excluding DOI
(test previously expected a bookChapter for
which the field is invalid and was changed in last
translators update but this part was not)

* Fix bibtex export as update to bibtex translator
changes how nullauthors affect the export of the
citation.

Please merge and deploy with
I6e901585b79f2564747f5b19c8b0c87aa0813bed

Bug: T166292
Change-Id: I4b118f634fb3746adf837d41213a051dd5555a5e
---
M test/features/scraping/export.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/citoid 
refs/changes/00/355600/1

diff --git a/test/features/scraping/export.js b/test/features/scraping/export.js
index c0e6462..c1e6505 100644
--- a/test/features/scraping/export.js
+++ b/test/features/scraping/export.js
@@ -16,7 +16,7 @@
         it('bibtex from scraper', function() {
             return server.query('http://example.com', 
'bibtex').then(function(res) {
                 assert.status(res, 200);
-                assert.checkBibtex(res, '\n@misc{_example_???');
+                assert.checkBibtex(res, '\n@misc{noauthor_exa');
             });
         });
 
@@ -44,7 +44,7 @@
                 assert.deepEqual(!!res.body[0].accessDate, true, 'No 
accessDate present');
                 assert.notDeepEqual(res.body[0].accessDate, 
'CURRENT_TIMESTAMP', 'Access date uncorrected');
                 assert.ok(res.body[0].creators);
-                assert.deepEqual(res.body[0].DOI, undefined, 'DOI is invalid 
field for type conferencePaper');
+                assert.deepEqual(res.body[0].DOI, '10.1007/11926078_68');
                 assert.deepEqual(res.body[0].itemType, 'conferencePaper', 
'Wrong itemType; expected conferencePaper, got' + res.body[0].itemType);
             });
         });

-- 
To view, visit https://gerrit.wikimedia.org/r/355600
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b118f634fb3746adf837d41213a051dd5555a5e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/citoid
Gerrit-Branch: master
Gerrit-Owner: Mvolz <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to