Mollgear has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/355874 )
Change subject: Making the default toggle look clickable again
......................................................................
Making the default toggle look clickable again
The toggle should now look same same prior to the premade toggle changes. The
brackets are not part of the link, but the text inbetween. The link has no href
property, so the toggle action is still triggered.
Bug: T166359
Change-Id: I38698cd66d380626728eae9b8a9da1e465b207a6
---
M resources/src/jquery/jquery.makeCollapsible.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/74/355874/1
diff --git a/resources/src/jquery/jquery.makeCollapsible.js
b/resources/src/jquery/jquery.makeCollapsible.js
index ac4a392..5ce9b1f 100644
--- a/resources/src/jquery/jquery.makeCollapsible.js
+++ b/resources/src/jquery/jquery.makeCollapsible.js
@@ -262,7 +262,7 @@
// Default toggle link. Only build it when needed to
avoid jQuery memory leaks (event data).
buildDefaultToggleLink = function () {
- return $( '<span
class="mw-collapsible-text"></span>' )
+ return $( '<a class="mw-collapsible-text"></a>'
)
.text( collapseText )
.wrap( '<span
class="mw-collapsible-toggle"></span>' ).parent()
.attr( {
--
To view, visit https://gerrit.wikimedia.org/r/355874
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38698cd66d380626728eae9b8a9da1e465b207a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Mollgear <moritz.oberhau...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
