Volans has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/355896 )

Change subject: Monitoring: remove spaces from list of interfaces
......................................................................

Monitoring: remove spaces from list of interfaces

- When generating the list of interfaces in check_eth, there are several
  whitespaces left for all the interfaces filtered. This clean the list
  without leaving whitespaces.

Bug: T166372
Change-Id: Ie642af5146b0273a5fa92d74218029ebcce1d915
---
M modules/base/templates/check_eth.erb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/96/355896/1

diff --git a/modules/base/templates/check_eth.erb 
b/modules/base/templates/check_eth.erb
index abbf21b..e1eec7c 100755
--- a/modules/base/templates/check_eth.erb
+++ b/modules/base/templates/check_eth.erb
@@ -1,6 +1,6 @@
 #!/bin/sh
 EXIT_CODE=0
-for INTERFACE in <%= @interfaces.gsub(',', ' 
').gsub(/\s\w+_\w+|tap\d+|vnet\d+|virbr\d|teredo|docker\d/,'') %> ; do
+for INTERFACE in <%= @interfaces.split(',').select{|i| not i =~ 
/\w+_\w+|tap\d+|vnet\d+|virbr\d|teredo|docker\d/}.join(' ') %> ; do
        REQ_SPEED=1000 # The default for now
        STATUS=`ip link show ${INTERFACE}`
        if [ "$?" != "0" ]; then

-- 
To view, visit https://gerrit.wikimedia.org/r/355896
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie642af5146b0273a5fa92d74218029ebcce1d915
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Volans <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to