jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/356014 )
Change subject: Apex theme: Make OptionWidget icon override more specific
......................................................................
Apex theme: Make OptionWidget icon override more specific
We're overriding option widget's selected state with a 'check' icon
but since we're doing that to any and all iconElements under the
option widget, it also picks up stray widgets that it should not.
The rule should only apply to the direct descendent iconElement-icon
of the widget so it doesn't override cases where the optionWidget
contains other icons or buttons.
Bug: T165444
Change-Id: Ibe4b4fc92de1a864059d9cd37168c7ef33b6d874
---
M src/themes/apex/widgets.less
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/src/themes/apex/widgets.less b/src/themes/apex/widgets.less
index 93b598b..ccea3bb 100644
--- a/src/themes/apex/widgets.less
+++ b/src/themes/apex/widgets.less
@@ -409,7 +409,7 @@
background-color: transparent;
// Hack to show 'check' icon in Apex, see T87835
- .oo-ui-iconElement-icon {
+ > .oo-ui-iconElement-icon {
.oo-ui-background-image-svg(
'@{oo-ui-default-image-path}/icons/check' );
background-position: center center;
background-repeat: no-repeat;
--
To view, visit https://gerrit.wikimedia.org/r/356014
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibe4b4fc92de1a864059d9cd37168c7ef33b6d874
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
