Faidon Liambotis has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/354079 )
Change subject: raid/hpssacli: WARN on permanently disabled cache
......................................................................
raid/hpssacli: WARN on permanently disabled cache
Commit 94f371f1f400a636694eead5a228285314a48db3 skipped the Cache Status
line of "controller slot=N show status", in an effort to make it not
warn on HP SSD Smart Path configurations where Cache Status was set to
"Not Configured". We were checking instead the LD Acceleration Status
for each logical drive, which was indicative in the past.
We have now seen a case out in the wild where Cache Status is set to
"Permanently Disabled", indicative of an issue with the hardware's
battery, but LDs all report "LD Acceleration Status: Controller Cache"
and "Caching: Enabled".
Change the Cache Status check to explicitly check for "OK" or "Not
Configured" and otherwise emit a WARNING.
Bug: T163998
Change-Id: Ib186044a8d349ca82f112c4f90da0ca20ccad96f
---
M modules/raid/files/dsa-check-hpssacli
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
Faidon Liambotis: Looks good to me, approved
jenkins-bot: Verified
Filippo Giunchedi: Looks good to me, but someone else must approve
Volans: Looks good to me, but someone else must approve
diff --git a/modules/raid/files/dsa-check-hpssacli
b/modules/raid/files/dsa-check-hpssacli
index 959198e..d10874b 100755
--- a/modules/raid/files/dsa-check-hpssacli
+++ b/modules/raid/files/dsa-check-hpssacli
@@ -309,8 +309,14 @@
my $system = $1;
my $status = $2;
- # skip the cache check, we track the LD Acceleration
Method above
- next if ($system eq 'Cache');
+ if ($system eq 'Cache') {
+ # Can be:
+ # - 'OK'
+ # - 'Not Configured' (for e.g. HP SSD Smart
Path)
+ # - 'Permanently Disabled'
+ # - ...?
+ next if $status =~ /^(OK|Not Configured)$/;
+ }
push @{$status{$status}}, $system;
if ($status ne 'OK') {
--
To view, visit https://gerrit.wikimedia.org/r/354079
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib186044a8d349ca82f112c4f90da0ca20ccad96f
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon Liambotis <[email protected]>
Gerrit-Reviewer: Faidon Liambotis <[email protected]>
Gerrit-Reviewer: Filippo Giunchedi <[email protected]>
Gerrit-Reviewer: Volans <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
