jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/354916 )
Change subject: tests: Cover ve.util#getCommonStartSequenceLength zero
sequences case
......................................................................
tests: Cover ve.util#getCommonStartSequenceLength zero sequences case
Change-Id: I10d44ca7fb475d3287ff8d416bbe9474b0cda748
---
M src/ve.utils.js
M tests/ve.test.js
2 files changed, 8 insertions(+), 2 deletions(-)
Approvals:
Esanders: Looks good to me, approved
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/src/ve.utils.js b/src/ve.utils.js
index 7166683..5e5d0d8 100644
--- a/src/ve.utils.js
+++ b/src/ve.utils.js
@@ -1384,15 +1384,16 @@
/**
* Find the length of the common start sequence of one or more sequences
*
+ * Items are tested for sameness using === .
*
* @param {Array} sequences Array of sequences (arrays, strings etc)
- * @return {number} Common start sequence length
+ * @return {number} Common start sequence length (0 if sequences is empty)
*/
ve.getCommonStartSequenceLength = function ( sequences ) {
var i, len, val,
commonLength = 0;
if ( sequences.length === 0 ) {
- throw new Error( 'Need at least one sequence' );
+ return 0;
}
commonLengthLoop:
while ( true ) {
diff --git a/tests/ve.test.js b/tests/ve.test.js
index 959b429..9a4dbfd 100644
--- a/tests/ve.test.js
+++ b/tests/ve.test.js
@@ -956,6 +956,11 @@
sequences: [ 'Cymru', 'Cymry', 'Cymraes', 'Cymro',
'Cymraeg' ],
commonLength: 4,
title: 'String sequences'
+ },
+ {
+ sequences: [],
+ commonLength: 0,
+ title: 'No sequences'
}
];
--
To view, visit https://gerrit.wikimedia.org/r/354916
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I10d44ca7fb475d3287ff8d416bbe9474b0cda748
Gerrit-PatchSet: 3
Gerrit-Project: VisualEditor/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
Gerrit-Reviewer: Divec <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
