jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/354879 )
Change subject: Don't fill in the skin's search box on Special:Search
......................................................................
Don't fill in the skin's search box on Special:Search
When viewing Special:Search, you usually see two search forms: the
small one provided by the skin (present on all pages), and the large
advanced search form generated by Special:Search.
Previously, both of these forms would be prefilled with the text that
was searched, which could lead to the user submitting the wrong form
after changing advanced search options.
After this change, the skin's search form will always start out empty.
There's no way for this to affect pages other than Special:Search,
since if the 'search' URL parameter is given, all requests are
redirected to Special:Search anyway (see MediaWiki::parseTitle()).
Bug: T106055
Change-Id: Ic6bb8af5383e7acfe4f823f563165cd60182753e
---
M includes/skins/BaseTemplate.php
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
Matt Fitzpatrick: Looks good to me, but someone else must approve
EBernhardson: Looks good to me, approved
jenkins-bot: Verified
Jforrester: Looks good to me, but someone else must approve
Isarra: Looks good to me, but someone else must approve
diff --git a/includes/skins/BaseTemplate.php b/includes/skins/BaseTemplate.php
index 5868904..0b7fc2f 100644
--- a/includes/skins/BaseTemplate.php
+++ b/includes/skins/BaseTemplate.php
@@ -523,7 +523,6 @@
'type' => 'search',
'name' => 'search',
'placeholder' => wfMessage( 'searchsuggest-search'
)->text(),
- 'value' => $this->get( 'search', '' ),
];
$realAttrs = array_merge( $realAttrs,
Linker::tooltipAndAccesskeyAttribs( 'search' ), $attrs );
return Html::element( 'input', $realAttrs );
--
To view, visit https://gerrit.wikimedia.org/r/354879
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic6bb8af5383e7acfe4f823f563165cd60182753e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Danny B. <[email protected]>
Gerrit-Reviewer: EBernhardson <[email protected]>
Gerrit-Reviewer: Isarra <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Matt Fitzpatrick <[email protected]>
Gerrit-Reviewer: MaxSem <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
