Nikerabbit has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/356325 )
Change subject: CX2: Define the data for TranslationTool independent of data model ...................................................................... CX2: Define the data for TranslationTool independent of data model The model.getId method adds model name to the output. A tool can be initiated from multiple models, So, for the tools, the data need not contain model name. Change-Id: I7ce8994c6cf11503d8ae509ab63976fb2d4e2cf8 --- M modules/tools/mw.cx.tools.TranslationTool.js 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Nikerabbit: Looks good to me, approved diff --git a/modules/tools/mw.cx.tools.TranslationTool.js b/modules/tools/mw.cx.tools.TranslationTool.js index 805310d..f974785 100644 --- a/modules/tools/mw.cx.tools.TranslationTool.js +++ b/modules/tools/mw.cx.tools.TranslationTool.js @@ -91,7 +91,7 @@ }; mw.cx.tools.TranslationTool.prototype.getData = function () { - return this.constructor.static.name + '::' + this.model.getId(); + return this.constructor.static.name + '::' + this.model.getSectionId(); }; /** -- To view, visit https://gerrit.wikimedia.org/r/356325 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7ce8994c6cf11503d8ae509ab63976fb2d4e2cf8 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits