jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/356327 )
Change subject: CX2: Guard against duplicate cards in the tools column
......................................................................
CX2: Guard against duplicate cards in the tools column
Since we defined multiple triggers for a single tool, if both
triggers happen at once, duplicate cards can appear in tools column.
For example, 'click', 'focus' can happen together.
Prevent duplicate cards appearing in translation column by checking
the data value of each cards.
Change-Id: I6a83a51aec7ba7c376dfe9785aeeb1a55fc73e33
---
M modules/ui/mw.cx.ui.ToolsColumn.js
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Nikerabbit: Looks good to me, approved
diff --git a/modules/ui/mw.cx.ui.ToolsColumn.js
b/modules/ui/mw.cx.ui.ToolsColumn.js
index 79609a3..11ba651 100644
--- a/modules/ui/mw.cx.ui.ToolsColumn.js
+++ b/modules/ui/mw.cx.ui.ToolsColumn.js
@@ -89,11 +89,15 @@
};
/**
- * Show a single tool in tools container
+ * Show a single tool in tools container.
+ * Avoid duplicates by checking if the tool is already in the container.
+ *
* @param {mw.cx.tools.TranslationTool} tool The translation tool instance
*/
mw.cx.ui.ToolsColumn.prototype.showTool = function ( tool ) {
- this.toolContainer.addItems( [ tool.getCard() ] );
+ if ( !this.toolContainer.getItemsFromData( tool.getData() ).length ) {
+ this.toolContainer.addItems( [ tool.getCard() ] );
+ }
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/356327
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6a83a51aec7ba7c376dfe9785aeeb1a55fc73e33
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
