Nikerabbit has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/356328 )
Change subject: CX2: Correct the data value for InstructionsTool ...................................................................... CX2: Correct the data value for InstructionsTool The InstructionsTool does not have any model associated. So calling model.getId will throw error. Set the data value as instructions::1 Change-Id: I6c3b24e0e019afa0b4c518e0e92b4bea342f92ff --- M modules/tools/mw.cx.tools.InstructionsTool.js 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: jenkins-bot: Verified Nikerabbit: Looks good to me, approved diff --git a/modules/tools/mw.cx.tools.InstructionsTool.js b/modules/tools/mw.cx.tools.InstructionsTool.js index 361fc98..29b9cf0 100644 --- a/modules/tools/mw.cx.tools.InstructionsTool.js +++ b/modules/tools/mw.cx.tools.InstructionsTool.js @@ -91,5 +91,9 @@ return $content; }; +mw.cx.tools.InstructionsTool.prototype.getData = function () { + return this.constructor.static.name + '::' + 1; +}; + /* Register */ mw.cx.tools.translationToolFactory.register( mw.cx.tools.InstructionsTool ); -- To view, visit https://gerrit.wikimedia.org/r/356328 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c3b24e0e019afa0b4c518e0e92b4bea342f92ff Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits