Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/356336 )
Change subject: Make some test assertions using isset() more specific
......................................................................
Make some test assertions using isset() more specific
Change-Id: I46c8614ee3e5f8d87828ad753f9d92dfee0eb14b
---
M client/tests/phpunit/includes/Hooks/OtherProjectsSidebarGeneratorTest.php
M client/tests/phpunit/includes/Hooks/UpdateRepoHookHandlersTest.php
2 files changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/36/356336/1
diff --git
a/client/tests/phpunit/includes/Hooks/OtherProjectsSidebarGeneratorTest.php
b/client/tests/phpunit/includes/Hooks/OtherProjectsSidebarGeneratorTest.php
index 7921ade..5a05837 100644
--- a/client/tests/phpunit/includes/Hooks/OtherProjectsSidebarGeneratorTest.php
+++ b/client/tests/phpunit/includes/Hooks/OtherProjectsSidebarGeneratorTest.php
@@ -184,8 +184,9 @@
),
'Hook inserts enwiki link' => array(
function( ItemId $itemId, array &$sidebar ) use
( $changedWikipedaLink ) {
- $this->assertFalse(
- isset( $sidebar['wikipedia'] ),
+ $this->assertArrayNotHasKey(
+ 'wikipedia',
+ $sidebar,
'No Wikipedia link present yet'
);
diff --git a/client/tests/phpunit/includes/Hooks/UpdateRepoHookHandlersTest.php
b/client/tests/phpunit/includes/Hooks/UpdateRepoHookHandlersTest.php
index 9f3c9c5..58604a6 100644
--- a/client/tests/phpunit/includes/Hooks/UpdateRepoHookHandlersTest.php
+++ b/client/tests/phpunit/includes/Hooks/UpdateRepoHookHandlersTest.php
@@ -113,7 +113,8 @@
'Move got propagated to repo.'
);
- $this->assertFalse( isset( $oldTitle->wikibasePushedMoveToRepo
), 'Should not touch $oldTitle' );
+ $this->assertFalse( property_exists( $oldTitle,
'wikibasePushedMoveToRepo' ),
+ 'Should not touch $oldTitle' );
}
public function testNewFromGlobalState() {
--
To view, visit https://gerrit.wikimedia.org/r/356336
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46c8614ee3e5f8d87828ad753f9d92dfee0eb14b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
