Thiemo Mättig (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/356354 )
Change subject: Make use of the …::class feature
......................................................................
Make use of the …::class feature
Change-Id: Ia71d0b378937425d6693aaa05ce65878cbb513a0
---
M composer.json
M tests/phpunit/includes/BeforePageDisplayHookHandlerTest.php
M tests/phpunit/includes/OtherProjectsSidebarHookHandlerTest.php
3 files changed, 8 insertions(+), 5 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaBadges
refs/changes/54/356354/1
diff --git a/composer.json b/composer.json
index 858c6a2..6d0b89c 100644
--- a/composer.json
+++ b/composer.json
@@ -21,7 +21,7 @@
"irc": "irc://irc.freenode.net/wikidata"
},
"require": {
- "php": ">=5.3.0"
+ "php": ">=5.5.9"
},
"autoload": {
"files": [
diff --git a/tests/phpunit/includes/BeforePageDisplayHookHandlerTest.php
b/tests/phpunit/includes/BeforePageDisplayHookHandlerTest.php
index 9a409b7..ba10619 100644
--- a/tests/phpunit/includes/BeforePageDisplayHookHandlerTest.php
+++ b/tests/phpunit/includes/BeforePageDisplayHookHandlerTest.php
@@ -2,6 +2,7 @@
namespace WikimediaBadges\Tests;
+use OutputPage;
use PHPUnit_Framework_TestCase;
use SkinTemplate;
use WikimediaBadges\BeforePageDisplayHookHandler;
@@ -18,7 +19,7 @@
public function testOnBeforePageDisplay() {
$skin = new SkinTemplate();
- $out = $this->getMockBuilder( 'OutputPage' )
+ $out = $this->getMockBuilder( OutputPage::class )
->disableOriginalConstructor()
->getMock();
$out->expects( $this->once() )
diff --git a/tests/phpunit/includes/OtherProjectsSidebarHookHandlerTest.php
b/tests/phpunit/includes/OtherProjectsSidebarHookHandlerTest.php
index 3ed8a93..913dc7c 100644
--- a/tests/phpunit/includes/OtherProjectsSidebarHookHandlerTest.php
+++ b/tests/phpunit/includes/OtherProjectsSidebarHookHandlerTest.php
@@ -8,10 +8,12 @@
use Wikibase\DataModel\Entity\Item;
use Wikibase\DataModel\Entity\ItemId;
use Wikibase\DataModel\Entity\PropertyId;
+use Wikibase\DataModel\Services\Lookup\EntityLookup;
use Wikibase\DataModel\Snak\PropertySomeValueSnak;
use Wikibase\DataModel\Snak\PropertyValueSnak;
use Wikibase\DataModel\Services\Lookup\InMemoryEntityLookup;
use Wikibase\DataModel\Services\Lookup\EntityLookupException;
+use Wikimedia\Assert\ParameterTypeException;
use WikimediaBadges\OtherProjectsSidebarHookHandler;
/**
@@ -119,7 +121,7 @@
}
public function testDoAddToSidebar_disabled() {
- $entityLookup = $this->getMock(
'Wikibase\DataModel\Services\Lookup\EntityLookup' );
+ $entityLookup = $this->getMock( EntityLookup::class );
$entityLookup->expects( $this->never() )
->method( 'getEntity' );
@@ -138,10 +140,10 @@
* @dataProvider constructor_invalidSettingProvider
*/
public function testConstructor_invalidSetting( $value ) {
- $this->setExpectedException(
'Wikimedia\Assert\ParameterTypeException' );
+ $this->setExpectedException( ParameterTypeException::class );
new OtherProjectsSidebarHookHandler(
- $this->getMock(
'Wikibase\DataModel\Services\Lookup\EntityLookup' ),
+ $this->getMock( EntityLookup::class ),
$value
);
}
--
To view, visit https://gerrit.wikimedia.org/r/356354
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia71d0b378937425d6693aaa05ce65878cbb513a0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaBadges
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
