jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/356395 )
Change subject: WindowManager: Fix important typo in deprecation warning
......................................................................
WindowManager: Fix important typo in deprecation warning
Bug: T166631
Change-Id: If39eab37828811f4f7964de23dcc20cb6ecd962d
---
M src/WindowManager.js
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/WindowManager.js b/src/WindowManager.js
index f5552ef..0dde041 100644
--- a/src/WindowManager.js
+++ b/src/WindowManager.js
@@ -494,7 +494,7 @@
lifecycle[ method ] = function () {
OO.ui.warnDeprecation(
'Using the return value of closeWindow
as a promise is deprecated. ' +
- 'Use .closeWindow( ... ).closing.' +
method + '( ... ) instead.'
+ 'Use .closeWindow( ... ).closed.' +
method + '( ... ) instead.'
);
return compatClosing[ method ].apply( this,
arguments );
};
--
To view, visit https://gerrit.wikimedia.org/r/356395
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If39eab37828811f4f7964de23dcc20cb6ecd962d
Gerrit-PatchSet: 2
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
