jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/356330 )
Change subject: Reduce maximum limit from 5000 to 50
......................................................................
Reduce maximum limit from 5000 to 50
It is very slow, so small maximum limit must be enforced to avoid
timeouts.
Bug: T155265
Follow-up: I9ed476fe208ea3
Change-Id: I1e036f9ea2314442c51ff02a972a21f5fe47070e
---
M pages/TalkpageView.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pages/TalkpageView.php b/pages/TalkpageView.php
index 11bab19..818634b 100644
--- a/pages/TalkpageView.php
+++ b/pages/TalkpageView.php
@@ -439,14 +439,14 @@
parent::__construct();
- $this->setLimit( $this->getPageLimit() );
+ $this->setLimit( min( 50, $this->getPageLimit() ) );
}
function getPageLimit() {
$article = $this->article;
global $wgRequest;
- $requestedLimit = $wgRequest->getVal( 'limit', null );
+ $requestedLimit = $wgRequest->getInt( 'limit', null );
if ( $requestedLimit ) {
return $requestedLimit;
}
--
To view, visit https://gerrit.wikimedia.org/r/356330
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1e036f9ea2314442c51ff02a972a21f5fe47070e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/LiquidThreads
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
