Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/356492 )
Change subject: [Whoops] Restore search results filtering tests
......................................................................
[Whoops] Restore search results filtering tests
There were some nice unit tests for filtering behavior in SuggestionsTask-
Test that were lumped in with an AsyncTask call test and got deleted in
I4bde23e. This restores them in a new test class.
Change-Id: I6a39211ec84b963ab43c664149f6a6a4bee5821d
---
A app/src/test/java/org/wikipedia/search/SearchResultsFilterTest.java
1 file changed, 51 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/92/356492/1
diff --git
a/app/src/test/java/org/wikipedia/search/SearchResultsFilterTest.java
b/app/src/test/java/org/wikipedia/search/SearchResultsFilterTest.java
new file mode 100644
index 0000000..1ee2c6b
--- /dev/null
+++ b/app/src/test/java/org/wikipedia/search/SearchResultsFilterTest.java
@@ -0,0 +1,51 @@
+package org.wikipedia.search;
+
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.wikipedia.Constants;
+import org.wikipedia.dataclient.WikiSite;
+import org.wikipedia.page.PageTitle;
+import org.wikipedia.test.TestRunner;
+
+import java.util.ArrayList;
+import java.util.List;
+
+import static org.hamcrest.Matchers.is;
+import static org.junit.Assert.assertThat;
+
+@RunWith(TestRunner.class) public class SearchResultsFilterTest {
+ private static final WikiSite WIKI = WikiSite.forLanguageCode("test");
+
+ @Test public void testFilterNoResults() {
+ List<SearchResult> originalResults = new ArrayList<>();
+ checkFilter(0, originalResults);
+ }
+
+ @Test public void testFilter1ResultSameAsTitleIgnoreCase() {
+ List<SearchResult> originalResults = new ArrayList<>();
+ originalResults.add(new SearchResult(new PageTitle("Test", WIKI, null,
null)));
+ checkFilter(0, originalResults);
+ }
+
+ @Test public void testFilter1ResultDifferentFromTitle() {
+ List<SearchResult> originalResults = new ArrayList<>();
+ originalResults.add(new SearchResult(new PageTitle("something else",
WIKI, null, null)));
+ checkFilter(1, originalResults);
+ }
+
+ @Test public void testFilter4ResultsDifferentFromTitle() {
+ List<SearchResult> originalResults = new ArrayList<>();
+ originalResults.add(new SearchResult(new PageTitle("something else",
WIKI, null, null)));
+ originalResults.add(new SearchResult(new PageTitle("something else",
WIKI, null, null)));
+ originalResults.add(new SearchResult(new PageTitle("something else",
WIKI, null, null)));
+ originalResults.add(new SearchResult(new PageTitle("something else",
WIKI, null, null)));
+ checkFilter(Constants.MAX_SUGGESTION_RESULTS, originalResults);
+ }
+
+ private void checkFilter(int expected, List<SearchResult> originalResults)
{
+ String title = "test";
+ SearchResults searchResults = new SearchResults(originalResults, null,
null);
+ List<SearchResult> filteredList = SearchResults.filter(searchResults,
title, false).getResults();
+ assertThat(expected, is(filteredList.size()));
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/356492
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a39211ec84b963ab43c664149f6a6a4bee5821d
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <mhollo...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
