jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/312962 )
Change subject: MWExceptionRenderer::useOutputPage: Don't bother if we have no
Title context
......................................................................
MWExceptionRenderer::useOutputPage: Don't bother if we have no Title context
Change-Id: Ieb6d682a9f2fb4def4c01908ccd035fcce2e1895
---
M includes/exception/MWExceptionRenderer.php
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
Chad: Looks good to me, approved
jenkins-bot: Verified
Jforrester: Looks good to me, but someone else must approve
diff --git a/includes/exception/MWExceptionRenderer.php
b/includes/exception/MWExceptionRenderer.php
index bd43934..5162a1f 100644
--- a/includes/exception/MWExceptionRenderer.php
+++ b/includes/exception/MWExceptionRenderer.php
@@ -96,9 +96,14 @@
}
}
+ // Don't even bother with OutputPage if there's no Title
context set,
+ // (e.g. we're in RL code on load.php) - the Skin system (and
probably
+ // most of MediaWiki) won't work.
+
return (
!empty( $GLOBALS['wgFullyInitialised'] ) &&
!empty( $GLOBALS['wgOut'] ) &&
+ RequestContext::getMain()->getTitle() &&
!defined( 'MEDIAWIKI_INSTALL' )
);
}
--
To view, visit https://gerrit.wikimedia.org/r/312962
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieb6d682a9f2fb4def4c01908ccd035fcce2e1895
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <kren...@gmail.com>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
