jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/356400 )
Change subject: Remove unused global ...................................................................... Remove unused global Change-Id: I945e797c59679229d957af9d1b78a2278ae5f54c --- M ContributionTracking.processor.php 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Hashar: Looks good to me, but someone else must approve jenkins-bot: Verified Ejegg: Looks good to me, approved diff --git a/ContributionTracking.processor.php b/ContributionTracking.processor.php index 83302d5..8bbd8a9 100644 --- a/ContributionTracking.processor.php +++ b/ContributionTracking.processor.php @@ -72,8 +72,6 @@ * @return array Staged key-value pairs ready to be saved as a contribution. */ static function stage_contribution( $params ) { - global $wgContributionTrackingUTMKey, $wgContributionTrackingAnalyticsUpgrade; - //change the posted names to match the db where necessary ContributionTrackingProcessor::rekey( $params, 'comment', 'note' ); @@ -90,15 +88,10 @@ /** * Stages the relevent data that will be sent to the gateway - * @global string $wgContributionTrackingPayPalRecurringIPN URL for paypal - * recurring donations : Defined in ContributionTracking.php - * @global string $wgContributionTrackingPayPalIPN URL for paypal recurring - * donations : Defined in ContributionTracking.php * @param array $params Parameters to post to the gateway * @return array Staged array */ static function stage_repost( $params ) { - global $wgContributionTrackingPayPalRecurringIPN, $wgContributionTrackingPayPalIPN; //TODO: assert that gateway makes The Sense here. //change the posted names to match the db where necessary ContributionTrackingProcessor::rekey( $params, 'amountGiven', 'amount_given' ); -- To view, visit https://gerrit.wikimedia.org/r/356400 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I945e797c59679229d957af9d1b78a2278ae5f54c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContributionTracking Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: Awight <awi...@wikimedia.org> Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits