Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/356522 )
Change subject: Avoid error suppressing
......................................................................
Avoid error suppressing
Silencing errors is discouraged
Change-Id: Icb681dd6a2ea3866d15b020bf82b4a66f6817d13
---
M backend/Subversion.php
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeReview
refs/changes/22/356522/1
diff --git a/backend/Subversion.php b/backend/Subversion.php
index f1caecd..bf71495 100644
--- a/backend/Subversion.php
+++ b/backend/Subversion.php
@@ -295,7 +295,8 @@
);
$document = new DOMDocument();
- if ( !@$document->loadXML( wfShellExec( $command ) ) ) {
+ $listXml = wfShellExec( $command );
+ if ( !$listXml || !$document->loadXML( $listXml ) ) {
// svn list --xml returns invalid XML if the file does
not exist
// FIXME: report bug upstream
return false;
--
To view, visit https://gerrit.wikimedia.org/r/356522
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb681dd6a2ea3866d15b020bf82b4a66f6817d13
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CodeReview
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
