jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/357364 )
Change subject: Simplify check for grammatical feature
......................................................................
Simplify check for grammatical feature
Change-Id: Ia433f260bd897d840b0d8395ac6b236e8b918c8e
---
M tests/browser/features/support/pages/lexeme_page.rb
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/support/pages/lexeme_page.rb
b/tests/browser/features/support/pages/lexeme_page.rb
index f3e75c0..a1364c0 100644
--- a/tests/browser/features/support/pages/lexeme_page.rb
+++ b/tests/browser/features/support/pages/lexeme_page.rb
@@ -38,9 +38,9 @@
page_section(:statement_group, StatementGroup, class:
'wikibase-statementgrouplistview')
def grammatical_feature?(label)
- self.grammatical_features_element.select do |gf_element|
+ self.grammatical_features_element.any? do |gf_element|
gf_element.text == label
- end.count > 0
+ end
end
end
--
To view, visit https://gerrit.wikimedia.org/r/357364
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia433f260bd897d840b0d8395ac6b236e8b918c8e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: Jakob <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
