jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/356277 )
Change subject: Remove incomplete PHPDoc @param tags
......................................................................
Remove incomplete PHPDoc @param tags
Plus:
* Add a missing "array" type hint.
* Use more specific assert… functions instead of isset().
Change-Id: Iaa423620d493b4bee11bf89f627d0420a645a8de
---
M tests/phpunit/LinksUpdateHookHandlerTest.php
1 file changed, 7 insertions(+), 8 deletions(-)
Approvals:
Pmiazga: Looks good to me, approved
jenkins-bot: Verified
Phuedx: Looks good to me, but someone else must approve
diff --git a/tests/phpunit/LinksUpdateHookHandlerTest.php
b/tests/phpunit/LinksUpdateHookHandlerTest.php
index 619d589..c33e64a 100644
--- a/tests/phpunit/LinksUpdateHookHandlerTest.php
+++ b/tests/phpunit/LinksUpdateHookHandlerTest.php
@@ -115,11 +115,12 @@
/**
* @dataProvider provideDoLinksUpdate
* @covers LinksUpdateHookHandler::doLinksUpdate
- * @param $images
- * @param $expectedFreeFileName
- * @param $expectedNonFreeFileName
*/
- public function testDoLinksUpdate( $images, $expectedFreeFileName,
$expectedNonFreeFileName ) {
+ public function testDoLinksUpdate(
+ array $images,
+ $expectedFreeFileName,
+ $expectedNonFreeFileName
+ ) {
$linksUpdate = $this->getLinksUpdate( $images );
$mock = TestingAccessWrapper::newFromObject(
$this->getMockBuilder(
LinksUpdateHookHandler::class )
@@ -147,12 +148,12 @@
$this->assertTrue( property_exists( $linksUpdate, 'mProperties'
), 'precondition' );
if ( is_null( $expectedFreeFileName ) ) {
- $this->assertFalse( isset(
$linksUpdate->mProperties[PageImages::PROP_NAME_FREE] ) );
+ $this->assertArrayNotHasKey(
PageImages::PROP_NAME_FREE, $linksUpdate->mProperties );
} else {
$this->assertSame( $expectedFreeFileName,
$linksUpdate->mProperties[PageImages::PROP_NAME_FREE] );
}
if ( is_null( $expectedNonFreeFileName ) ) {
- $this->assertFalse( isset(
$linksUpdate->mProperties[PageImages::PROP_NAME] ) );
+ $this->assertArrayNotHasKey( PageImages::PROP_NAME,
$linksUpdate->mProperties );
} else {
$this->assertSame( $expectedNonFreeFileName,
$linksUpdate->mProperties[PageImages::PROP_NAME] );
}
@@ -324,8 +325,6 @@
/**
* @dataProvider provideIsFreeImage
- * @param $fileName
- * @param $metadata
* @covers LinksUpdateHookHandler::isImageFree
*/
public function testIsFreeImage( $fileName, $metadata, $expected ) {
--
To view, visit https://gerrit.wikimedia.org/r/356277
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa423620d493b4bee11bf89f627d0420a645a8de
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/PageImages
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: Phuedx <[email protected]>
Gerrit-Reviewer: Pmiazga <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
