Ema has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/357617 )

Change subject: check_ipmi_temp: load ipmi_devintf
......................................................................


check_ipmi_temp: load ipmi_devintf

If /dev/ipmi0 is not available, multiple IPMI software can communicate
inband to the BMC simultaneously, subsequently racing with each other.
Ultimately, this can lead to communication problems. In FreeIPMI, this
is most commonly seen through "internal IPMI error" or "driver busy"
messages.

Ensure that the ipmi_devintf kernel module is loaded and /dev/ipmi0
created.

Bug: T125205
Bug: T167121
Ref: 
http://www.gnu.org/software/freeipmi/freeipmi-faq.html#Why-am-I-seeing-so-many-_0027internal-IPMI-error_0027-or-_0027driver-busy_0027-messages_003f
Change-Id: I41b2c0a71b27cadf37c79bf2fda893d33d75f1cd
---
M modules/base/manifests/monitoring/host.pp
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Muehlenhoff: Looks good to me, but someone else must approve
  Ema: Verified; Looks good to me, approved
  Filippo Giunchedi: Looks good to me, but someone else must approve
  Dzahn: Looks good to me, but someone else must approve



diff --git a/modules/base/manifests/monitoring/host.pp 
b/modules/base/manifests/monitoring/host.pp
index ef0b7cd..9f83042 100644
--- a/modules/base/manifests/monitoring/host.pp
+++ b/modules/base/manifests/monitoring/host.pp
@@ -158,6 +158,16 @@
 
     # check temperature sensors via IPMI, unless VM (T125205)
     if str2bool($facts['is_virtual']) == false {
+        # ipmi_devintf needs to be loaded for the checks to work properly
+        # (T167121)
+        file { '/etc/modules-load.d/ipmi.conf':
+            ensure  => present,
+            owner   => 'root',
+            group   => 'root',
+            mode    => '0444',
+            content => "ipmi_devintf\n",
+            require => File['/etc/modules-load.d/'],
+        }
 
         ::sudo::user { 'nagios_ipmi_temp':
             user       => 'nagios',

-- 
To view, visit https://gerrit.wikimedia.org/r/357617
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I41b2c0a71b27cadf37c79bf2fda893d33d75f1cd
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ema <e...@wikimedia.org>
Gerrit-Reviewer: Dzahn <dz...@wikimedia.org>
Gerrit-Reviewer: Ema <e...@wikimedia.org>
Gerrit-Reviewer: Faidon Liambotis <fai...@wikimedia.org>
Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org>
Gerrit-Reviewer: Gehel <guillaume.leder...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Herron <kher...@wikimedia.org>
Gerrit-Reviewer: Muehlenhoff <mmuhlenh...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to