jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/357822 )
Change subject: Fix possible crash when viewing reading lists.
......................................................................
Fix possible crash when viewing reading lists.
When setting the Toolbar title in the reading list screen, a window was
open for a NPE to slip through.
Change-Id: I4719b6b425dc597b1e5f37044c481da7eaa4297d
---
M app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Mholloway: Looks good to me, approved
diff --git
a/app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.java
b/app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.java
index cf88509..fb35b0b 100644
--- a/app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.java
+++ b/app/src/main/java/org/wikipedia/readinglist/ReadingListFragment.java
@@ -511,7 +511,7 @@
getAppCompatActivity().supportInvalidateOptionsMenu();
} else if (verticalOffset <= -appBarLayout.getTotalScrollRange()
&& !showOverflowMenu) {
showOverflowMenu = true;
- toolBarLayout.setTitle(readingList.getTitle());
+ toolBarLayout.setTitle(readingList != null ?
readingList.getTitle() : null);
getAppCompatActivity().supportInvalidateOptionsMenu();
}
}
--
To view, visit https://gerrit.wikimedia.org/r/357822
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4719b6b425dc597b1e5f37044c481da7eaa4297d
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Mholloway <[email protected]>
Gerrit-Reviewer: Niedzielski <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
