jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/357455 )
Change subject: Put static after visibility in functions ...................................................................... Put static after visibility in functions This order is usually used Change-Id: Ibf0cd157adb3924e220b01cea54fc6858b318444 --- M includes/Banner.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: jenkins-bot: Verified Ejegg: Looks good to me, approved diff --git a/includes/Banner.php b/includes/Banner.php index b09caab..49e36fe 100644 --- a/includes/Banner.php +++ b/includes/Banner.php @@ -1144,7 +1144,7 @@ * @param integer $pageId ID of the MediaWiki page for the banner * @throws Exception */ - static protected function removeTag( $tag, $pageId ) { + protected static function removeTag( $tag, $pageId ) { $dbw = CNDatabase::getDb(); $conds = array( -- To view, visit https://gerrit.wikimedia.org/r/357455 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibf0cd157adb3924e220b01cea54fc6858b318444 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/CentralNotice Gerrit-Branch: master Gerrit-Owner: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com> Gerrit-Reviewer: Awight <awi...@wikimedia.org> Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org> Gerrit-Reviewer: Ejegg <ej...@ejegg.com> Gerrit-Reviewer: XenoRyet <dkozlow...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits