jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/358142 )
Change subject: Fix UI regression - normalize heading font size ...................................................................... Fix UI regression - normalize heading font size Introduced by: I1ee00148a248d3725b02eea3c19e6b22486ae5ba Notification and edit overlay have titles that are too big. Removed the variable since it is only used in one place and is just for normalization. It's not useful. Change-Id: Ic824aab9e94b623203669d43e4def149fea30c4b --- M minerva.less/minerva.variables.less M resources/mobile.startup/Overlay.less 2 files changed, 2 insertions(+), 1 deletion(-) Approvals: Pmiazga: Looks good to me, approved jenkins-bot: Verified diff --git a/minerva.less/minerva.variables.less b/minerva.less/minerva.variables.less index 575a4ac..d39c222 100644 --- a/minerva.less/minerva.variables.less +++ b/minerva.less/minerva.variables.less @@ -18,7 +18,6 @@ @contentMargin: 16px; // Header -@headerTitleFontSize: 1em; @headerHeight: 3.35em; @headerMarginTop: -1px; // used to hide the header border top when a banner is not present @searchBoxWidth: 375/16em; diff --git a/resources/mobile.startup/Overlay.less b/resources/mobile.startup/Overlay.less index 313deaf..dc2a938 100644 --- a/resources/mobile.startup/Overlay.less +++ b/resources/mobile.startup/Overlay.less @@ -227,6 +227,8 @@ h2 { display: table; width: 100%; + // reset default headings. Overide default font size. + font-size: 1em; > * { width: 1em; -- To view, visit https://gerrit.wikimedia.org/r/358142 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic824aab9e94b623203669d43e4def149fea30c4b Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Pmiazga <pmia...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits