jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/357575 )
Change subject: Update documentation of badge data structure in SidebarLinkBadgeDisplay ...................................................................... Update documentation of badge data structure in SidebarLinkBadgeDisplay Badge item's label is stored under 'label' key not 'itemtitle'. Change-Id: Ie29afc2e1f1d29c3a3df5e9d5968214a9d671fb1 --- M client/includes/Hooks/SidebarLinkBadgeDisplay.php 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Aude: Looks good to me, approved jenkins-bot: Verified diff --git a/client/includes/Hooks/SidebarLinkBadgeDisplay.php b/client/includes/Hooks/SidebarLinkBadgeDisplay.php index 91927ea..b4094ba 100644 --- a/client/includes/Hooks/SidebarLinkBadgeDisplay.php +++ b/client/includes/Hooks/SidebarLinkBadgeDisplay.php @@ -52,7 +52,7 @@ * This is generally called in the context of generating skin output. * * @param string[] &$sidebarLink - * @param string[] $badgeInfo An associative array with the keys 'class' and 'itemtitle' with assigned + * @param string[] $badgeInfo An associative array with the keys 'class' and 'label' with assigned * string values. These fields are the one outputted by the getBadgeInfo() function. */ public function applyBadgeToLink( array &$sidebarLink, array $badgeInfo ) { @@ -84,9 +84,9 @@ * * @param ItemId[] $badgeIds * - * @return string[] An associative array with the keys 'class' and 'itemtitle' with assigned + * @return string[] An associative array with the keys 'class' and 'label' with assigned * string values. These fields correspond to the fields in the description array for language - * links used by the SkinTemplateGetLanguageLink hook and expected by the applyBadges() + * links used by the SkinTemplateGetLanguageLink hook and expected by the applyBadgeToLink() * function. */ public function getBadgeInfo( array $badgeIds ) { -- To view, visit https://gerrit.wikimedia.org/r/357575 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie29afc2e1f1d29c3a3df5e9d5968214a9d671fb1 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: WMDE-leszek <leszek.mani...@wikimedia.de> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits