jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/357990 )
Change subject: Grey out RankSelector when the state is active
......................................................................
Grey out RankSelector when the state is active
Bug: T85388
Change-Id: I84704ae65e560b7e517aac20f00ec389cfd1310b
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
M
view/resources/jquery/wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css
2 files changed, 7 insertions(+), 4 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git
a/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
index b60c832..3bfbe20 100644
---
a/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
+++
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
@@ -301,7 +301,7 @@
draw: function() {
if ( this.isInEditMode() ) {
this.element
- .addClass( 'ui-state-default ui-state-active' )
+ .addClass( 'ui-state-default' )
.removeClass( 'ui-state-disabled' );
} else {
this.element
diff --git
a/view/resources/jquery/wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css
b/view/resources/jquery/wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css
index 3835fc0..042ccff 100644
---
a/view/resources/jquery/wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css
+++
b/view/resources/jquery/wikibase/themes/default/jquery.wikibase.statementview.RankSelector.css
@@ -31,15 +31,18 @@
background-position: -18px;
}
-.wikibase-rankselector.ui-state-disabled
.ui-icon.wikibase-rankselector-preferred {
+.wikibase-rankselector.ui-state-disabled
.ui-icon.wikibase-rankselector-preferred,
+.wb-edit.wikibase-rankselector.ui-state-active
.ui-icon.wikibase-rankselector-preferred {
background-position: -27px;
}
-.wikibase-rankselector.ui-state-disabled .ui-icon.wikibase-rankselector-normal
{
+.wikibase-rankselector.ui-state-disabled .ui-icon.wikibase-rankselector-normal,
+.wb-edit.wikibase-rankselector.ui-state-active
.ui-icon.wikibase-rankselector-normal {
background-position: -36px;
}
-.wikibase-rankselector.ui-state-disabled
.ui-icon.wikibase-rankselector-deprecated {
+.wikibase-rankselector.ui-state-disabled
.ui-icon.wikibase-rankselector-deprecated,
+.wb-edit.wikibase-rankselector.ui-state-active
.ui-icon.wikibase-rankselector-deprecated {
background-position: -45px;
}
--
To view, visit https://gerrit.wikimedia.org/r/357990
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I84704ae65e560b7e517aac20f00ec389cfd1310b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
