jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/357991 )
Change subject: Make /* globals */ directive unnecessary
......................................................................
Make /* globals */ directive unnecessary
eslint already knows about the global variables mediaWiki, jQuery and
OO, so if we use the long names instead of $ and mw, the globals
directive can be removed completely.
Change-Id: I20efe3759c6cb3c6d6a9e2397c784c18846058ce
---
M .eslintrc.json
M docs/user.js
2 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Lucas Werkmeister (WMDE): Looks good to me, approved
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, but someone else must approve
diff --git a/.eslintrc.json b/.eslintrc.json
index 15268a4..a03258b 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -4,6 +4,10 @@
"browser": true,
"jquery": true
},
+ "globals": {
+ "mediaWiki": false,
+ "OO": false
+ },
"rules": {
"keyword-spacing": "off",
"space-before-function-paren": "off",
diff --git a/docs/user.js b/docs/user.js
index 2e7ca3a..6868f79 100644
--- a/docs/user.js
+++ b/docs/user.js
@@ -1,5 +1,3 @@
-/* globals mw, $, OO */
-
( function( mw, $, OO ) {
'use strict';
@@ -123,4 +121,4 @@
} );
} );
}
-} )( mw, $, OO );
+} )( mediaWiki, jQuery, OO );
--
To view, visit https://gerrit.wikimedia.org/r/357991
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20efe3759c6cb3c6d6a9e2397c784c18846058ce
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
