jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/358143 )
Change subject: Update Fresco to 1.3.0 ...................................................................... Update Fresco to 1.3.0 v1.2.0 and v1.3.0 are described as "mainly bugfix release[s]." No updates to copied samples. https://github.com/facebook/fresco/releases Change-Id: I1eec747a10fe7d52358c72c8f62f7289c61e7dfa --- M app/build.gradle M app/proguard-rules.pro 2 files changed, 7 insertions(+), 1 deletion(-) Approvals: Dbrant: Looks good to me, approved jenkins-bot: Verified diff --git a/app/build.gradle b/app/build.gradle index 80b2a5a..9292d3b 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -168,7 +168,7 @@ String supportVersion = '25.3.1' String espressoVersion = '2.2.2' String butterKnifeVersion = '8.5.1' - String frescoVersion = '1.1.0' // When updating this version, resync file copies under + String frescoVersion = '1.3.0' // When updating this version, resync file copies under // app/src/main/java/com/facebook String testingSupportVersion = '0.5' String mockitoCore = 'org.mockito:mockito-core:1.9.5' diff --git a/app/proguard-rules.pro b/app/proguard-rules.pro index e1be86f..8e71e08 100644 --- a/app/proguard-rules.pro +++ b/app/proguard-rules.pro @@ -19,6 +19,12 @@ #-dontwarn okio.** -dontwarn javax.annotation.** -dontwarn com.android.volley.toolbox.** + +#-dontwarn for the ReturnsOwnership or Functional classes (used only by Infer) +# https://github.com/facebook/fresco/issues/1716 +-dontwarn com.facebook.infer.annotation.ReturnsOwnership +-dontwarn com.facebook.infer.annotation.Functional + # --- /Fresco --- # --- Butter Knife --- -- To view, visit https://gerrit.wikimedia.org/r/358143 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1eec747a10fe7d52358c72c8f62f7289c61e7dfa Gerrit-PatchSet: 2 Gerrit-Project: apps/android/wikipedia Gerrit-Branch: master Gerrit-Owner: Mholloway <mhollo...@wikimedia.org> Gerrit-Reviewer: Brion VIBBER <br...@wikimedia.org> Gerrit-Reviewer: Dbrant <dbr...@wikimedia.org> Gerrit-Reviewer: Niedzielski <sniedziel...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits