Ladsgroup has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358963 )
Change subject: [WIP] Reword Echo notification text
......................................................................
[WIP] Reword Echo notification text
Bug: T164375
Change-Id: I1e939765b2c3f5c4cccc76ff506f0aeb7b5cb01f
---
M client/i18n/en.json
M client/includes/Hooks/EchoNotificationsHandlers.php
M client/includes/Notifications/PageConnectionPresentationModel.php
3 files changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/63/358963/1
diff --git a/client/i18n/en.json b/client/i18n/en.json
index 8e341d2..1ab4d8a 100644
--- a/client/i18n/en.json
+++ b/client/i18n/en.json
@@ -125,7 +125,7 @@
"wikibase-otherprojects-beta-description": "Adds an
\"{{int:wikibase-otherprojects}}\" section to the sidebar that provides links
to the other Wikimedia projects based on {{WBREPONAME}} data.",
"echo-category-title-wikibase-action":
"{{PLURAL:$1|Connection|Connections}} with {{WBREPONAME}}",
"echo-pref-tooltip-wikibase-action": "Notify me when someone connects a
page {{GENDER:|I created}} to a {{WBREPONAME}} item.",
- "notification-header-page-connection": "The page <strong>$3</strong>
was {{GENDER:$2|connected}} to a {{WBREPONAME}} item.",
+ "notification-header-page-connection": "The page <strong>$3</strong>
was {{GENDER:$2|connected}} to the {{WBREPONAME}} item $4, which contains data
relevant to the topic.",
"notification-bundle-header-page-connection": "<strong>$3</strong> and
{{PLURAL:$4|one other page|$4 other pages|100=99+ other pages}} were
{{GENDER:$2|connected}} to {{WBREPONAME}} items.",
"notification-link-text-view-item": "{{GENDER:$1|View}} item",
"notification-subject-page-connection": "A page on {{SITENAME}} you
{{GENDER:$3|created}} was {{GENDER:$2|connected}} to a {{WBREPONAME}} item",
diff --git a/client/includes/Hooks/EchoNotificationsHandlers.php
b/client/includes/Hooks/EchoNotificationsHandlers.php
index 3c0ff36..34f9370 100644
--- a/client/includes/Hooks/EchoNotificationsHandlers.php
+++ b/client/includes/Hooks/EchoNotificationsHandlers.php
@@ -234,6 +234,7 @@
// maybe also a diff link?
'url' =>
$this->repoLinker->getEntityUrl( $entityId ),
'repoSiteName' => $this->repoSiteName,
+ 'entity' =>
$entityId->getSerialization(),
],
'title' => $title,
'type' => self::NOTIFICATION_TYPE
diff --git a/client/includes/Notifications/PageConnectionPresentationModel.php
b/client/includes/Notifications/PageConnectionPresentationModel.php
index a3c15f4..c727078 100644
--- a/client/includes/Notifications/PageConnectionPresentationModel.php
+++ b/client/includes/Notifications/PageConnectionPresentationModel.php
@@ -58,7 +58,8 @@
if ( $count > 0 ) {
$msg = $this->getMessageWithAgent(
"notification-bundle-header-{$this->type}" )
->params( $truncated )
- ->numParams( $count );
+ ->numParams( $count )
+ ->params( $this->event->getExtraParam( 'entity'
) );
} else {
$msg = $this->getMessageWithAgent(
"notification-header-{$this->type}" )
->params( $truncated );
--
To view, visit https://gerrit.wikimedia.org/r/358963
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1e939765b2c3f5c4cccc76ff506f0aeb7b5cb01f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
