Lucas Werkmeister (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358971 )
Change subject: Remove unnecessary strtoupper
......................................................................
Remove unnecessary strtoupper
The ItemId and PropertyId constructors already apply strtoupper to the
local ID part, and calling array_map without assigning the result to
anything was pointless anyways.
Change-Id: Ieea0d0c0d0bf55098d68d1f1c9c094915f4f5abc
---
M includes/ConstraintCheck/Helper/ConstraintStatementParameterParser.php
1 file changed, 1 insertion(+), 2 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseQualityConstraints
refs/changes/71/358971/1
diff --git
a/includes/ConstraintCheck/Helper/ConstraintStatementParameterParser.php
b/includes/ConstraintCheck/Helper/ConstraintStatementParameterParser.php
index e3e01df..82bc97a 100644
--- a/includes/ConstraintCheck/Helper/ConstraintStatementParameterParser.php
+++ b/includes/ConstraintCheck/Helper/ConstraintStatementParameterParser.php
@@ -258,7 +258,6 @@
private function parsePropertyParameterFromTemplate( array
$constraintParameters ) {
try {
$properties = explode( ',',
$constraintParameters['property'] );
- array_map( 'strtoupper', $properties );
return new PropertyId( $properties[0] ); // silently
ignore extra properties (Mandatory Qualifiers used to allow several properties)
} catch ( InvalidArgumentException $e ) {
throw new ConstraintParameterException(
@@ -342,7 +341,7 @@
break;
default:
try {
- $values[] =
ItemIdSnakValue::fromItemId( new ItemId( strtoupper( $value ) ) );
+ $values[] =
ItemIdSnakValue::fromItemId( new ItemId( $value ) );
break;
} catch ( InvalidArgumentException $e )
{
throw new
ConstraintParameterException(
--
To view, visit https://gerrit.wikimedia.org/r/358971
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieea0d0c0d0bf55098d68d1f1c9c094915f4f5abc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
