jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/358954 )
Change subject: Add stylelint for css files
......................................................................
Add stylelint for css files
Fixed the following rules:
- selector-list-comma-newline-after
- lector-pseudo-class-parentheses-space-inside
- color-hex-case
- declaration-property-value-blacklist
Change-Id: I9782f8aeaf34d96060b5731cc840f47213f1ac96
---
A .stylelintrc
M Gruntfile.js
M modules/ext.newsletter.newsletters.styles.css
M package.json
4 files changed, 35 insertions(+), 12 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/.stylelintrc b/.stylelintrc
new file mode 100644
index 0000000..2c90730
--- /dev/null
+++ b/.stylelintrc
@@ -0,0 +1,3 @@
+{
+ "extends": "stylelint-config-wikimedia"
+}
diff --git a/Gruntfile.js b/Gruntfile.js
index d76be53..2460a7d 100644
--- a/Gruntfile.js
+++ b/Gruntfile.js
@@ -4,6 +4,7 @@
grunt.loadNpmTasks( 'grunt-jsonlint' );
grunt.loadNpmTasks( 'grunt-banana-checker' );
grunt.loadNpmTasks( 'grunt-jscs' );
+ grunt.loadNpmTasks( 'grunt-stylelint' );
grunt.initConfig( {
jshint: {
@@ -24,11 +25,18 @@
jsonlint: {
all: [
'**/*.json',
+ '.stylelintrc',
+ '!node_modules/**'
+ ]
+ },
+ stylelint: {
+ all: [
+ '**/*.css',
'!node_modules/**'
]
}
} );
- grunt.registerTask( 'test', [ 'jshint', 'jscs', 'jsonlint', 'banana' ]
);
+ grunt.registerTask( 'test', [ 'jshint', 'jscs', 'jsonlint', 'banana',
'stylelint' ] );
grunt.registerTask( 'default', 'test' );
};
diff --git a/modules/ext.newsletter.newsletters.styles.css
b/modules/ext.newsletter.newsletters.styles.css
index ab2d9d7..c3cd71f 100644
--- a/modules/ext.newsletter.newsletters.styles.css
+++ b/modules/ext.newsletter.newsletters.styles.css
@@ -7,6 +7,7 @@
* submits the form for them. The associated JS code is located at
ext.newsletter.newsletters
* module. This is done here instead of that module to prevent FOUCs.
*/
+/* stylelint-disable-next-line selector-no-id */
.client-js #mw-newsletter-filter-submit {
display: none;
}
@@ -14,29 +15,34 @@
/**
* The default dropdown is rather wide so we'll make it a bit small to make it
look nicer.
*/
+/* stylelint-disable-next-line selector-no-id */
#mw-newsletter-filter-options {
width: 40%;
}
/* Styling for "Subscribe/Unsubscribe" links */
.newsletter-subscribed,
-.newsletter-subscribed:link, .newsletter-subscribed:visited {
- color: #13385A;
+.newsletter-subscribed:link,
+.newsletter-subscribed:visited {
+ color: #13385a;
font-weight: bold;
}
-.newsletter-subscribed:hover, .newsletter-subscribed:active {
+.newsletter-subscribed:hover,
+.newsletter-subscribed:active {
color: #0c1f30;
text-decoration: none;
}
.newsletter-unsubscribed,
-.newsletter-unsubscribed:link, .newsletter-unsubscribed:visited {
+.newsletter-unsubscribed:link,
+.newsletter-unsubscribed:visited {
color: #245e8f;
font-weight: bold;
}
-.newsletter-unsubscribed:hover, .newsletter-unsubscribed:active {
+.newsletter-unsubscribed:hover,
+.newsletter-unsubscribed:active {
color: #173d5d;
text-decoration: none;
}
@@ -46,14 +52,18 @@
cursor: default;
}
-.mw-special-Newsletters .mw-datatable, .mw-special-Newsletters .mw-datatable
td, .mw-special-Newsletters .mw-datatable th {
- border: none;
+.mw-special-Newsletters .mw-datatable,
+.mw-special-Newsletters .mw-datatable td,
+.mw-special-Newsletters .mw-datatable th {
+ border: 0;
}
-.mw-special-Newsletters .mw-datatable, .mw-special-Newsletters .mw-datatable
tr {
- border: solid #AAAAAA;
+.mw-special-Newsletters .mw-datatable,
+.mw-special-Newsletters .mw-datatable tr {
+ border: solid #aaa;
border-width: 0 0 1px 0;
}
-.mw-special-Newsletters .mw-datatable td:nth-child(3), .mw-special-Newsletters
.mw-datatable td:nth-child(4) {
+.mw-special-Newsletters .mw-datatable td:nth-child( 3 ),
+.mw-special-Newsletters .mw-datatable td:nth-child( 4 ) {
text-align: center;
}
diff --git a/package.json b/package.json
index 8a4e5f3..cb7e8d5 100644
--- a/package.json
+++ b/package.json
@@ -8,6 +8,8 @@
"grunt-contrib-jshint": "0.11.3",
"grunt-banana-checker": "0.4.0",
"grunt-jscs": "2.5.0",
- "grunt-jsonlint": "1.0.7"
+ "grunt-jsonlint": "1.0.7",
+ "grunt-stylelint": "0.7.0",
+ "stylelint-config-wikimedia": "0.4.1"
}
}
--
To view, visit https://gerrit.wikimedia.org/r/358954
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9782f8aeaf34d96060b5731cc840f47213f1ac96
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
