Bartosz Dziewoński has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359051 )
Change subject: ve.ui.MWEducationPopupTool: Remove unnecessary manual popup positioning ...................................................................... ve.ui.MWEducationPopupTool: Remove unnecessary manual popup positioning OOjs UI Popups position themselves automatically relative to their $floatableContainer these days. Also added explicit `$floatableContainer: this.$element` in the config (although not strictly needed, since the parent node is used by default, this makes the code more robust in case we move the popup somewhere else in the DOM). Bug: T167751 Change-Id: Id4267fce6499a4c217f7dc1d18871c02dd078aee --- M modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js 1 file changed, 1 insertion(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/51/359051/1 diff --git a/modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js b/modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js index c610ae2..ecc2424 100644 --- a/modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js +++ b/modules/ve-mw/ui/tools/ve.ui.MWEducationPopupTool.js @@ -55,6 +55,7 @@ ); this.popup = new OO.ui.PopupWidget( { + $floatableContainer: this.$element, $content: $popupContent, padded: true, width: 300 @@ -79,10 +80,6 @@ tool.$pulsatingDot.hide(); tool.$stillDot.hide(); tool.popup.toggle( true ); - tool.popup.$element.css( { - left: tool.$element.width() / 2, - top: tool.$element.height() - } ); $shield.remove(); } } ); -- To view, visit https://gerrit.wikimedia.org/r/359051 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id4267fce6499a4c217f7dc1d18871c02dd078aee Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Bartosz Dziewoński <matma....@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits