Gehel has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/352126 )
Change subject: elasticsearch - cleanup profile::elasticsearch
......................................................................
elasticsearch - cleanup profile::elasticsearch
move class variable to class parameters to follow new guidelines
Change-Id: Ifcbf6d6066501f5b21a8394fd5dd1ff5c3d28569
---
M modules/profile/manifests/elasticsearch.pp
1 file changed, 17 insertions(+), 17 deletions(-)
Approvals:
jenkins-bot: Verified
Gehel: Looks good to me, approved
diff --git a/modules/profile/manifests/elasticsearch.pp
b/modules/profile/manifests/elasticsearch.pp
index ffe22d0..8a7bbb2 100644
--- a/modules/profile/manifests/elasticsearch.pp
+++ b/modules/profile/manifests/elasticsearch.pp
@@ -10,23 +10,23 @@
#
# For documentation of other parameters, see the elasticsearch class.
#
-class profile::elasticsearch {
- $cluster_name = hiera('profile::elasticsearch::cluster_name')
- $ferm_srange = hiera('profile::elasticsearch::ferm_srange')
- $cluster_hosts = hiera('profile::elasticsearch::cluster_hosts')
- $unicast_hosts = hiera('profile::elasticsearch::unicast_hosts')
- $minimum_master_nodes =
hiera('profile::elasticsearch::minimum_master_nodes')
- $heap_memory = hiera('profile::elasticsearch::heap_memory')
- $expected_nodes = hiera('profile::elasticsearch::expected_nodes')
- $graylog_hosts = hiera('profile::elasticsearch::graylog_hosts')
- $rack = hiera('profile::elasticsearch::rack')
- $row = hiera('profile::elasticsearch::row')
- $awareness_attributes =
hiera('profile::elasticsearch::awareness_attributes')
- $bulk_thread_pool_executors =
hiera('profile::elasticsearch::bulk_thread_pool_executors', 6)
- $certificate_name = hiera('profile::elasticsearch::certificate_name',
$::fqdn)
- $recover_after_time = hiera('profile::elasticsearch::recover_after_time',
'1s')
- $recover_after_nodes =
hiera('profile::elasticsearch::recover_after_nodes', 1)
-
+class profile::elasticsearch(
+ $cluster_name = hiera('profile::elasticsearch::cluster_name'),
+ $ferm_srange = hiera('profile::elasticsearch::ferm_srange'),
+ $cluster_hosts = hiera('profile::elasticsearch::cluster_hosts'),
+ $unicast_hosts = hiera('profile::elasticsearch::unicast_hosts'),
+ $minimum_master_nodes =
hiera('profile::elasticsearch::minimum_master_nodes'),
+ $heap_memory = hiera('profile::elasticsearch::heap_memory'),
+ $expected_nodes = hiera('profile::elasticsearch::expected_nodes'),
+ $graylog_hosts = hiera('profile::elasticsearch::graylog_hosts'),
+ $rack = hiera('profile::elasticsearch::rack'),
+ $row = hiera('profile::elasticsearch::row'),
+ $awareness_attributes =
hiera('profile::elasticsearch::awareness_attributes'),
+ $bulk_thread_pool_executors =
hiera('profile::elasticsearch::bulk_thread_pool_executors', 6),
+ $certificate_name = hiera('profile::elasticsearch::certificate_name',
$::fqdn),
+ $recover_after_time = hiera('profile::elasticsearch::recover_after_time',
'1s'),
+ $recover_after_nodes =
hiera('profile::elasticsearch::recover_after_nodes', 1),
+) {
$master_eligible = $::fqdn in $unicast_hosts
ferm::service { 'elastic-http':
--
To view, visit https://gerrit.wikimedia.org/r/352126
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcbf6d6066501f5b21a8394fd5dd1ff5c3d28569
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Gehel <guillaume.leder...@wikimedia.org>
Gerrit-Reviewer: Gehel <guillaume.leder...@wikimedia.org>
Gerrit-Reviewer: Giuseppe Lavagetto <glavage...@wikimedia.org>
Gerrit-Reviewer: Volans <rcocci...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
