Matěj Suchánek has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359385 )
Change subject: Show a warning in edit preview when a template loop is detected
......................................................................
Show a warning in edit preview when a template loop is detected
Follow-up to Ib888634af.
Bug: T162149
Change-Id: I870dc22c984c900568ccacdc88d1bd31194394e1
---
M includes/parser/Parser.php
M languages/i18n/en.json
M languages/i18n/qqq.json
3 files changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/85/359385/1
diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index d8722ba..c0a648c 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -3261,6 +3261,8 @@
. wfMessage(
'parser-template-loop-warning', $titleText )->inContentLanguage()->text()
. '</span>';
$this->addTrackingCategory(
'template-loop-category' );
+ $this->mOutput->addWarning( wfMessage(
'template-loop-warning',
+ wfEscapeWikiText( $titleText )
)->text() );
wfDebug( __METHOD__ . ": template loop broken
at '$titleText'\n" );
}
}
diff --git a/languages/i18n/en.json b/languages/i18n/en.json
index 766acf3..fad1314 100644
--- a/languages/i18n/en.json
+++ b/languages/i18n/en.json
@@ -778,6 +778,7 @@
"parser-template-loop-warning": "Template loop detected: [[$1]]",
"template-loop-category": "Pages with template loops",
"template-loop-category-desc": "The page contains a template loop, ie.
a template which calls itself recursively.",
+ "template-loop-warning": "<strong>Warning:</strong> This page calls
[[:$1]] which causes a template loop (an infinite recursive call).",
"parser-template-recursion-depth-warning": "Template recursion depth
limit exceeded ($1)",
"language-converter-depth-warning": "Language converter depth limit
exceeded ($1)",
"node-count-exceeded-category": "Pages where node count is exceeded",
diff --git a/languages/i18n/qqq.json b/languages/i18n/qqq.json
index 73033d6..ae15883 100644
--- a/languages/i18n/qqq.json
+++ b/languages/i18n/qqq.json
@@ -968,6 +968,7 @@
"parser-template-loop-warning": "Parameters:\n* $1 - page title",
"template-loop-category": "This message is used as a category name for
a [[mw:Special:MyLanguage/Help:Tracking categories|tracking category]] where
pages with template loops will be listed.",
"template-loop-category-desc": "Pages with template loops category
description. Shown on [[Special:TrackingCategories]].\n\nSee also:\n*
{{msg-mw|Template-loop-category}}",
+ "template-loop-warning": "This message is displayed in edit preview
when a template loop is detected on the previewed page.\n\nParameters:\n* $1 -
the full title of template which causes the template loop.",
"parser-template-recursion-depth-warning": "Parameters:\n* $1 - limit
value of recursion depth",
"language-converter-depth-warning": "Error message shown when a page
uses too deeply nested language conversion syntax. Parameters:\n* $1 - the
value of the depth limit",
"node-count-exceeded-category": "This message is used as a category
name for a [[mw:Help:Tracking categories|tracking category]] where pages are
placed automatically if the node-count of the preprocessor exceeds the
limit.\n\nSee also:\n* {{msg-mw|Node-count-exceeded-warning}}",
--
To view, visit https://gerrit.wikimedia.org/r/359385
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I870dc22c984c900568ccacdc88d1bd31194394e1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
