[MediaWiki-commits] [Gerrit] In MW integration, dialog was overlapping toolbar shadow. - change (mediawiki...VisualEditor)

[Robmoen (Code Review)]

Robmoen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/52884


Change subject: In MW integration, dialog was overlapping toolbar shadow.
......................................................................

In MW integration, dialog was overlapping toolbar shadow.

Setting the top to the outerHeight of the toolbar solves this.

Change-Id: I528ce23c88dfe6a3be7d4f7c4f6c90ef608630c1
---
M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/84/52884/1

diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js 
b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
index 6ec51c6..569aaf7 100644
--- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js
@@ -1657,7 +1657,7 @@
 
        setDialogSize();
        // Put the dialog just under the toolbar.
-       dialog.$.css( { 'top': $toolbar.height() } );
+       dialog.$.css( { 'top': $toolbar.outerHeight() } );
 
        // Events
        $( window ).on( { 'resize.ve-dialog': setDialogSize } );

-- 
To view, visit https://gerrit.wikimedia.org/r/52884
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I528ce23c88dfe6a3be7d4f7c4f6c90ef608630c1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Robmoen <rm...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits