Umherirrender has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359635 )
Change subject: phpcs: Set whitelist for
MediaWiki.NamingConventions.ValidGlobalName
......................................................................
phpcs: Set whitelist for MediaWiki.NamingConventions.ValidGlobalName
Instead of excluding the whole sniff, use the ignorelist to avoid adding
new wrong named globals
Change-Id: Ia60bdfb2e7c1e95519c9ea7341eaa808cd16cc6d
---
M phpcs.xml
1 file changed, 5 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/35/359635/1
diff --git a/phpcs.xml b/phpcs.xml
index c724f2e..1a0d461 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -5,13 +5,15 @@
<arg name="extensions" value="php,php5,inc"/>
<arg name="encoding" value="utf8"/>
<exclude-pattern>vendor</exclude-pattern>
+ <rule ref="MediaWiki.NamingConventions.ValidGlobalName">
+ <properties>
+ <property name="ignoreList" type="array"
value="$parserMemc,$mediaWiki" />
+ </properties>
+ </rule>
<rule
ref="Generic.CodeAnalysis.ForLoopWithTestFunctionCall.NotAllowed">
<severity>0</severity>
</rule>
<rule ref="Generic.Files.LineLength.TooLong">
- <severity>0</severity>
- </rule>
- <rule ref="MediaWiki.NamingConventions.ValidGlobalName.wgPrefix">
<severity>0</severity>
</rule>
<rule ref="Squiz.Classes.ValidClassName.NotCamelCaps">
--
To view, visit https://gerrit.wikimedia.org/r/359635
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia60bdfb2e7c1e95519c9ea7341eaa808cd16cc6d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
