Giuseppe Lavagetto has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/359950 )

Change subject: role::redis::jobqueue: fixup crontabs
......................................................................

role::redis::jobqueue: fixup crontabs

Change-Id: I1f070324658930bc3d0a72a2f3725f45804e3d4f
---
M modules/profile/manifests/redis/jobqueue.pp
M modules/profile/manifests/redis/jobqueue_slave.pp
2 files changed, 4 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/50/359950/1

diff --git a/modules/profile/manifests/redis/jobqueue.pp 
b/modules/profile/manifests/redis/jobqueue.pp
index f6cb081..da37315 100644
--- a/modules/profile/manifests/redis/jobqueue.pp
+++ b/modules/profile/manifests/redis/jobqueue.pp
@@ -14,8 +14,9 @@
         group  => 'root',
     }
 
+    $instance_str = join($::profile::redis::multidc::instances, ' ')
     cron { 'jobqueue-redis-conditional-restart':
-        command => "/usr/local/bin/restart-redis-if-slave 
${::profile::redis::multidc::instances}",
+        command => "/usr/local/bin/restart-redis-if-slave ${instance_str}",
         hour    => 1,
         minute  => 0,
     }
diff --git a/modules/profile/manifests/redis/jobqueue_slave.pp 
b/modules/profile/manifests/redis/jobqueue_slave.pp
index f4ec731..39b3f59 100644
--- a/modules/profile/manifests/redis/jobqueue_slave.pp
+++ b/modules/profile/manifests/redis/jobqueue_slave.pp
@@ -13,9 +13,9 @@
         owner  => 'root',
         group  => 'root',
     }
-
+    $instance_str = join($::profile::redis::slave::instances, ' ')
     cron { 'jobqueue-redis-conditional-restart':
-        command => "/usr/local/bin/restart-redis-if-slave 
${::profile::redis::slave::instances}",
+        command => "/usr/local/bin/restart-redis-if-slave ${instance_str}",
         hour    => 1,
         minute  => 0,
     }

-- 
To view, visit https://gerrit.wikimedia.org/r/359950
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1f070324658930bc3d0a72a2f3725f45804e3d4f
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Giuseppe Lavagetto <glavage...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to