Pmiazga has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359954 )
Change subject: Do not show empty HTML previews ...................................................................... Do not show empty HTML previews When HTML doesn't contain text nodes return an empty array instead of empty HTML tags. Previously there was an issue as '<p>(Bar)</p> would be transformed into '<p></p>' after parenthesis stripping and passed to renderer. As '<p></p>' is not empty content it would render blank page preview instad of generic one. This patch should fix that scenario. Bug: T165018 Change-Id: I72b67ad6f2e37d77dea83445ce5510e7fa16d4b0 --- M resources/dist/index.js M resources/dist/index.js.map M src/formatter.js M src/gateway/restFormatters.js M tests/node-qunit/formatter.test.js 5 files changed, 47 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Popups refs/changes/54/359954/1 -- To view, visit https://gerrit.wikimedia.org/r/359954 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I72b67ad6f2e37d77dea83445ce5510e7fa16d4b0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Pmiazga <pmia...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
