Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/360158 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
The following sniffs are failing and were disabled:
* MediaWiki.FunctionComment.Missing.Public
Change-Id: Ib6231fc316b20d493a0c39eda2d3422690abcd58
---
M composer.json
M phpcs.xml
2 files changed, 6 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FileExporter
refs/changes/58/360158/1
diff --git a/composer.json b/composer.json
index 664b9b4..7a306bc 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9.2",
- "mediawiki/mediawiki-codesniffer": "0.7.2",
+ "mediawiki/mediawiki-codesniffer": "0.9.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index 2993420..88d11be 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,10 +1,11 @@
<?xml version="1.0"?>
<ruleset name="FileExporter">
- <!-- See
https://github.com/wikimedia/mediawiki-tools-codesniffer/blob/master/MediaWiki/ruleset.xml
-->
+
<rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.ControlStructures.AssignmentInControlStructures" />
<exclude name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment" />
- </rule>
+ <exclude name="MediaWiki.FunctionComment.Missing.Public" />
+ </rule>
<rule ref="Generic.Files.InlineHTML" />
<rule ref="Generic.Files.OneInterfacePerFile" />
@@ -17,7 +18,7 @@
<exclude name="PSR1.Files.SideEffects" />
</rule>
<rule ref="PSR1.Methods.CamelCapsMethodName.NotCamelCaps">
- <!-- Exclude test methods like
"testGivenInvalidInput_methodThrowsException". -->
+
<exclude-pattern>/tests/phpunit/*Test\.php</exclude-pattern>
</rule>
@@ -44,4 +45,4 @@
<arg name="extensions" value="php" />
<arg name="encoding" value="utf8" />
<exclude-pattern>vendor</exclude-pattern>
-</ruleset>
\ No newline at end of file
+</ruleset>
--
To view, visit https://gerrit.wikimedia.org/r/360158
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6231fc316b20d493a0c39eda2d3422690abcd58
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FileExporter
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
