Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/360182 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.FunctionComment.Missing.Protected
* MediaWiki.FunctionComment.Missing.Public
* MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment
Change-Id: Icc5b559f01ec580eefd79b04c7d4b99a191660ee
---
M composer.json
M phpcs.xml
M removeOldManualUserPages.php
M tests/phpunit/ResourceLoaderGlobalSiteModuleTest.php
M tests/phpunit/ResourceLoaderGlobalUserModuleTest.php
5 files changed, 11 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GlobalCssJs
refs/changes/82/360182/1
diff --git a/composer.json b/composer.json
index b3f1e93..4e39ef0 100644
--- a/composer.json
+++ b/composer.json
@@ -1,7 +1,7 @@
{
"require-dev": {
"jakub-onderka/php-parallel-lint": "0.9",
- "mediawiki/mediawiki-codesniffer": "0.7.2",
+ "mediawiki/mediawiki-codesniffer": "0.9.0",
"jakub-onderka/php-console-highlighter": "0.3.2"
},
"scripts": {
diff --git a/phpcs.xml b/phpcs.xml
index f3eb9fd..50e4637 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,10 +1,16 @@
<?xml version="1.0"?>
<ruleset>
<rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
- <exclude name="Generic.Files.LineLength"/>
+ <exclude name="Generic.Files.LineLength" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
+ <exclude name="MediaWiki.FunctionComment.Missing.Protected" />
+ <exclude name="MediaWiki.FunctionComment.Missing.Public" />
+ <exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
</rule>
<file>.</file>
- <arg name="extensions" value="php,php5,inc"/>
- <arg name="encoding" value="utf8"/>
+ <arg name="extensions" value="php,php5,inc" />
+ <arg name="encoding" value="utf8" />
<exclude-pattern>vendor</exclude-pattern>
</ruleset>
diff --git a/removeOldManualUserPages.php b/removeOldManualUserPages.php
index ee798b3..1170b68 100644
--- a/removeOldManualUserPages.php
+++ b/removeOldManualUserPages.php
@@ -201,4 +201,4 @@
}
$maintClass = "RemoveOldManualUserPages";
-require_once ( RUN_MAINTENANCE_IF_MAIN );
+require_once RUN_MAINTENANCE_IF_MAIN;
diff --git a/tests/phpunit/ResourceLoaderGlobalSiteModuleTest.php
b/tests/phpunit/ResourceLoaderGlobalSiteModuleTest.php
index 0456aa2..8d12aff 100644
--- a/tests/phpunit/ResourceLoaderGlobalSiteModuleTest.php
+++ b/tests/phpunit/ResourceLoaderGlobalSiteModuleTest.php
@@ -3,7 +3,6 @@
class ResourceLoaderGlobalSiteModuleTest extends
ResourceLoaderGlobalModuleTestCase {
public static function provideGetPages() {
-
// format: array( $type, array( config => value ),
$expectedPages, $skin, $description )
return [
[
diff --git a/tests/phpunit/ResourceLoaderGlobalUserModuleTest.php
b/tests/phpunit/ResourceLoaderGlobalUserModuleTest.php
index 3709725..284687e 100644
--- a/tests/phpunit/ResourceLoaderGlobalUserModuleTest.php
+++ b/tests/phpunit/ResourceLoaderGlobalUserModuleTest.php
@@ -13,7 +13,6 @@
}
public static function provideGetPages() {
-
// format: array( $type, array( config => value ),
$expectedPages, $description )
return [
[
--
To view, visit https://gerrit.wikimedia.org/r/360182
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icc5b559f01ec580eefd79b04c7d4b99a191660ee
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GlobalCssJs
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
