Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/360288 )
Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
......................................................................
build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.MissingReturn
* MediaWiki.Commenting.FunctionComment.ParamNameNoCaseMatch
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.Commenting.FunctionComment.WrongStyle
* MediaWiki.FunctionComment.Missing.Protected
* MediaWiki.FunctionComment.Missing.Public
* MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment
Change-Id: Ic63ce962bd9f097723571f19122083b64c94093a
---
M WikimediaEventsHooks.php
M composer.json
M phpcs.xml
M tests/phpunit/AuthManagerStatsdHandlerTest.php
4 files changed, 20 insertions(+), 13 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents
refs/changes/88/360288/1
diff --git a/WikimediaEventsHooks.php b/WikimediaEventsHooks.php
index 958c1e5..295cee8 100644
--- a/WikimediaEventsHooks.php
+++ b/WikimediaEventsHooks.php
@@ -65,7 +65,6 @@
// Imported from EventLogging extension
public static function onPageContentSaveComplete( $article, $user,
$content, $summary,
$isMinor, $isWatch, $section, $flags, $revision, $status,
$baseRevId ) {
-
if ( !$revision ) {
return;
}
@@ -298,7 +297,6 @@
*/
protected static function logPageCreation( User $user, $pageId, Title
$title,
$revId ) {
-
EventLogging::logEvent( 'PageCreation', 7481635, [
'userId' => $user->getId(),
'userText' => $user->getName(),
@@ -364,7 +362,6 @@
*/
public static function onPageContentInsertComplete( WikiPage $wikiPage,
User $user,
Content $content, $summary, $isMinor, $isWatch, $section,
$flags, Revision $revision ) {
-
$title = $wikiPage->getTitle();
self::logPageCreation( $user, $wikiPage->getId(), $title,
$revision->getId() );
diff --git a/composer.json b/composer.json
index e6a9f5e..a8afc57 100644
--- a/composer.json
+++ b/composer.json
@@ -1,14 +1,14 @@
{
- "name" : "mediawiki/wikimediaevents",
- "type" : "mediawiki-extension",
- "license" : "GPL-2.0+",
+ "name": "mediawiki/wikimediaevents",
+ "type": "mediawiki-extension",
+ "license": "GPL-2.0+",
"minimum-stability": "dev",
- "require-dev" : {
+ "require-dev": {
"facebook/webdriver": "1.1.1",
"symfony/css-selector": "3.1.0",
"jakub-onderka/php-parallel-lint": "0.9.2",
"jakub-onderka/php-console-highlighter": "0.3.2",
- "mediawiki/mediawiki-codesniffer": "0.7.2"
+ "mediawiki/mediawiki-codesniffer": "0.9.0"
},
"scripts": {
"fix": "phpcbf",
diff --git a/phpcs.xml b/phpcs.xml
index ede6c5d..bd6c3cc 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,9 +1,20 @@
-<?xml version="1.0" encoding="UTF-8"?>
+<?xml version="1.0"?>
<ruleset>
- <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+ <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.MissingReturn" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoCaseMatch" />
+ <exclude
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
+ <exclude name="MediaWiki.Commenting.FunctionComment.WrongStyle"
/>
+ <exclude name="MediaWiki.FunctionComment.Missing.Protected" />
+ <exclude name="MediaWiki.FunctionComment.Missing.Public" />
+ <exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
+ </rule>
<file>.</file>
- <arg name="extensions" value="php,php5,inc"/>
- <arg name="encoding" value="utf8"/>
+ <arg name="extensions" value="php,php5,inc" />
+ <arg name="encoding" value="utf8" />
<exclude-pattern>vendor</exclude-pattern>
<exclude-pattern>node_modules</exclude-pattern>
</ruleset>
diff --git a/tests/phpunit/AuthManagerStatsdHandlerTest.php
b/tests/phpunit/AuthManagerStatsdHandlerTest.php
index 19478c2..ae78c6f 100644
--- a/tests/phpunit/AuthManagerStatsdHandlerTest.php
+++ b/tests/phpunit/AuthManagerStatsdHandlerTest.php
@@ -98,4 +98,3 @@
];
}
}
-
--
To view, visit https://gerrit.wikimedia.org/r/360288
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic63ce962bd9f097723571f19122083b64c94093a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
