Legoktm has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/360290 )

Change subject: build: Updating mediawiki/mediawiki-codesniffer to 0.9.0
......................................................................

build: Updating mediawiki/mediawiki-codesniffer to 0.9.0

The following sniffs are failing and were disabled:
* MediaWiki.Commenting.FunctionComment.MissingParamComment
* MediaWiki.Commenting.FunctionComment.MissingParamName
* MediaWiki.Commenting.FunctionComment.MissingParamTag
* MediaWiki.Commenting.FunctionComment.ParamNameNoMatch
* MediaWiki.FunctionComment.Missing.Public
* MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment

Change-Id: I7ba29ba423c07aa71910f6ea4a9a41936c05b4f8
---
M .gitignore
M WikimediaMessages.hooks.php
M composer.json
M phpcs.xml
4 files changed, 13 insertions(+), 6 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaMessages 
refs/changes/90/360290/1

diff --git a/.gitignore b/.gitignore
index 4b56e91..07f782d 100644
--- a/.gitignore
+++ b/.gitignore
@@ -4,3 +4,4 @@
 *~
 *.kate-swp
 .*.swp
+composer.lock
diff --git a/WikimediaMessages.hooks.php b/WikimediaMessages.hooks.php
index 6a11392..4733df2 100644
--- a/WikimediaMessages.hooks.php
+++ b/WikimediaMessages.hooks.php
@@ -1310,7 +1310,6 @@
 
        public static function onResourceLoaderRegisterModules( ResourceLoader 
&$resourceLoader ) {
                if ( class_exists( 'GuidedTourHooks' ) ) {
-
                        $resourceLoader->register( 
'ext.guidedTour.tour.RcFiltersBeta', [
                                'localBasePath' => __DIR__ . '/modules',
                                'remoteExtPath' => 'WikimediaMessages/modules',
diff --git a/composer.json b/composer.json
index b8f68fb..4a8c744 100644
--- a/composer.json
+++ b/composer.json
@@ -2,7 +2,7 @@
        "require-dev": {
                "jakub-onderka/php-parallel-lint": "0.9.2",
                "jakub-onderka/php-console-highlighter": "0.3.2",
-               "mediawiki/mediawiki-codesniffer": "0.7.2"
+               "mediawiki/mediawiki-codesniffer": "0.9.0"
        },
        "scripts": {
                "fix": "phpcbf",
diff --git a/phpcs.xml b/phpcs.xml
index a62b8c6..f5b606e 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -1,14 +1,21 @@
-<?xml version="1.0" encoding="UTF-8"?>
+<?xml version="1.0"?>
 <ruleset>
-       <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki"/>
+       <rule ref="vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamName" />
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.MissingParamTag" />
+               <exclude 
name="MediaWiki.Commenting.FunctionComment.ParamNameNoMatch" />
+               <exclude name="MediaWiki.FunctionComment.Missing.Public" />
+               <exclude 
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
+       </rule>
        <rule ref="MediaWiki.NamingConventions.ValidGlobalName">
                <properties>
                        <property name="ignoreList" type="array" 
value="$wmfRealm" />
                </properties>
        </rule>
        <file>.</file>
-       <arg name="extensions" value="php,php5,inc"/>
-       <arg name="encoding" value="utf8"/>
+       <arg name="extensions" value="php,php5,inc" />
+       <arg name="encoding" value="utf8" />
        <exclude-pattern>vendor</exclude-pattern>
        <exclude-pattern>node_modules</exclude-pattern>
 </ruleset>

-- 
To view, visit https://gerrit.wikimedia.org/r/360290
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7ba29ba423c07aa71910f6ea4a9a41936c05b4f8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaMessages
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to