jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/358957 )
Change subject: i13n: Log EL events with mw.track ...................................................................... i13n: Log EL events with mw.track Currently, the mw.eventLog.Schema class samples per pageview. However, we expect that if a user is bucketed for a session, then all EventLogging events logged during that session are in the sample. Moreover, loading the class in the way that we did - asynchronously, using mw.loader#using - introduced an issue where the eventLogging change listener would subscribe in the next tick of the JavaScript VM's event loop and miss the "pageLoaded" event being queued (see T167273). Changes: * Make the schema module follow the form of the statsvInstrumentation module, i.e. make it expose the #isEnabled method, and add the associated getEventLoggingTracker function. * Update the eventLogging change listener accept the tracker returned by getEventLoggingTracker. * Update/fix related JSDoc documentation. Bug: T167236 Bug: T167273 Change-Id: I4f653bbaf1bbc2c2f70327e338080e17cd3443d4 --- M resources/dist/index.js M resources/dist/index.js.map M src/changeListeners/eventLogging.js M src/changeListeners/statsv.js M src/index.js M src/schema.js M tests/node-qunit/changeListeners/eventLogging.test.js M tests/node-qunit/schema.test.js 8 files changed, 164 insertions(+), 93 deletions(-) Approvals: Jhernandez: Looks good to me, approved jenkins-bot: Verified Jdlrobson: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/358957 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4f653bbaf1bbc2c2f70327e338080e17cd3443d4 Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: Phuedx <[email protected]> Gerrit-Reviewer: BarryTheBrowserTestBot <[email protected]> Gerrit-Reviewer: Bmansurov <[email protected]> Gerrit-Reviewer: Frankiebot <[email protected]> Gerrit-Reviewer: Jdlrobson <[email protected]> Gerrit-Reviewer: Jhernandez <[email protected]> Gerrit-Reviewer: Phuedx <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
