Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/360360 )
Change subject: Update WikiErrorView colors when in the gallery
......................................................................
Update WikiErrorView colors when in the gallery
Gave it a black background to match the gallery context and brightened
up the icon and text.
Bug: T167460
Change-Id: I88f91ee78eff4cee0d590118cfadfee69f8a6e67
---
M app/src/main/java/org/wikipedia/gallery/GalleryActivity.java
M app/src/main/res/layout/activity_gallery.xml
M app/src/main/res/values/colors.xml
3 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/60/360360/1
diff --git a/app/src/main/java/org/wikipedia/gallery/GalleryActivity.java
b/app/src/main/java/org/wikipedia/gallery/GalleryActivity.java
index c48a494..f9fcdde 100644
--- a/app/src/main/java/org/wikipedia/gallery/GalleryActivity.java
+++ b/app/src/main/java/org/wikipedia/gallery/GalleryActivity.java
@@ -195,6 +195,10 @@
creditText.setShadowLayer(2, 1, 1, color(R.color.lead_text_shadow));
errorView = (WikiErrorView) findViewById(R.id.view_gallery_error);
+ ((ImageView) errorView.findViewById(R.id.view_wiki_error_icon))
+ .setColorFilter(ContextCompat.getColor(this,
R.color.view_wiki_error_icon_tint_light));
+ ((TextView) errorView.findViewById(R.id.view_wiki_error_text))
+ .setTextColor(ContextCompat.getColor(this,
R.color.view_wiki_error_text_color_light));
errorView.setBackClickListener(new View.OnClickListener() {
@Override
public void onClick(View v) {
diff --git a/app/src/main/res/layout/activity_gallery.xml
b/app/src/main/res/layout/activity_gallery.xml
index 86ffd14..55bfe04 100644
--- a/app/src/main/res/layout/activity_gallery.xml
+++ b/app/src/main/res/layout/activity_gallery.xml
@@ -13,7 +13,7 @@
android:layout_height="match_parent"
android:layout_gravity="center"
android:orientation="vertical"
- android:background="@color/base80"
+ android:background="@android:color/black"
android:visibility="gone"/>
<android.support.v4.view.ViewPager
diff --git a/app/src/main/res/values/colors.xml
b/app/src/main/res/values/colors.xml
index 5cb3f47..ddc19c3 100644
--- a/app/src/main/res/values/colors.xml
+++ b/app/src/main/res/values/colors.xml
@@ -135,6 +135,8 @@
<color name="view_wiki_error_icon_tint">@color/base30</color>
<color name="view_wiki_error_text_color">@color/base30</color>
+ <color name="view_wiki_error_icon_tint_light">@color/base70</color>
+ <color name="view_wiki_error_text_color_light">@color/base70</color>
<color name="page_action_tab_enabled">@android:color/white</color>
<color name="page_action_tab_disabled">@color/base30</color>
--
To view, visit https://gerrit.wikimedia.org/r/360360
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I88f91ee78eff4cee0d590118cfadfee69f8a6e67
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
