jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/352052 )
Change subject: Specify output directory for make-exchange-refs
......................................................................
Specify output directory for make-exchange-refs
Change-Id: Ia3c15c1670266f78581bcb21a4e9296379c54df6
---
M sites/all/modules/exchange_rates/make_exchange_refs.drush.inc
M sites/all/modules/exchange_rates/templates/ref_source.php.twig
2 files changed, 8 insertions(+), 4 deletions(-)
Approvals:
Mepps: Looks good to me, approved
jenkins-bot: Verified
diff --git a/sites/all/modules/exchange_rates/make_exchange_refs.drush.inc
b/sites/all/modules/exchange_rates/make_exchange_refs.drush.inc
index 65f9994..5796d84 100644
--- a/sites/all/modules/exchange_rates/make_exchange_refs.drush.inc
+++ b/sites/all/modules/exchange_rates/make_exchange_refs.drush.inc
@@ -8,7 +8,12 @@
function make_exchange_refs_drush_command() {
$items['make-exchange-refs'] = array(
'description' => 'Generate CurrencyRates.php static exchange rate
class.',
- 'examples' => array( 'drush make-exchange-refs' ),
+ 'arguments' => array(
+ 'output-dir' => 'The directory in which to write the
output file',
+ ),
+ 'required-arguments' => true,
+ 'examples' => array( 'drush make-exchange-refs /home/foo/generated' ),
+
);
return $items;
}
@@ -23,10 +28,9 @@
}
}
-function drush_make_exchange_refs() {
+function drush_make_exchange_refs( $dir ) {
$rates = module_invoke( 'exchange_rates', 'get_conversions' );
- $dir = __DIR__ . '/generated/';
if ( !is_dir( $dir ) ) {
mkdir( $dir );
}
diff --git a/sites/all/modules/exchange_rates/templates/ref_source.php.twig
b/sites/all/modules/exchange_rates/templates/ref_source.php.twig
index 4cf8336..19d7b3a 100644
--- a/sites/all/modules/exchange_rates/templates/ref_source.php.twig
+++ b/sites/all/modules/exchange_rates/templates/ref_source.php.twig
@@ -2,7 +2,7 @@
/**
* Automatically generated from {{ generated_by }}
* -- do not edit! --
- * Instead, run drush make-exchange-refs and look in the 'generated' folder.
+ * Instead, run drush make-exchange-refs /output/dir and look in the specified
folder.
*/
class CurrencyRates {
--
To view, visit https://gerrit.wikimedia.org/r/352052
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia3c15c1670266f78581bcb21a4e9296379c54df6
Gerrit-PatchSet: 2
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: master
Gerrit-Owner: Ejegg <[email protected]>
Gerrit-Reviewer: AndyRussG <[email protected]>
Gerrit-Reviewer: Awight <[email protected]>
Gerrit-Reviewer: Cdentinger <[email protected]>
Gerrit-Reviewer: Eileen <[email protected]>
Gerrit-Reviewer: Ejegg <[email protected]>
Gerrit-Reviewer: Katie Horn <[email protected]>
Gerrit-Reviewer: Mepps <[email protected]>
Gerrit-Reviewer: XenoRyet <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
