jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/360375 )
Change subject: Fix registration form URL validation
......................................................................
Fix registration form URL validation
Bug: T168417
Change-Id: I9079ff16bbb35e7c03c5de6802ac06cc52866e93
---
M control/MWOAuthConsumerSubmitControl.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Anomie: Looks good to me, approved
diff --git a/control/MWOAuthConsumerSubmitControl.php
b/control/MWOAuthConsumerSubmitControl.php
index 3d829ba..ff214e3 100644
--- a/control/MWOAuthConsumerSubmitControl.php
+++ b/control/MWOAuthConsumerSubmitControl.php
@@ -72,7 +72,7 @@
'name' => '/^.{1,128}$/',
'version' =>
'/^\d{1,3}(\.\d{1,2}){0,2}(-(dev|alpha|beta))?$/',
'callbackUrl' => function( $s, $vals ) {
- return $vals['ownerOnly'] ||
wfParseUrl( $s ) !== null;
+ return $vals['ownerOnly'] ||
wfParseUrl( $s ) !== false;
},
'description' => '/^.*$/s',
'email' => function( $s ) {
--
To view, visit https://gerrit.wikimedia.org/r/360375
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9079ff16bbb35e7c03c5de6802ac06cc52866e93
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
