Lucas Werkmeister (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/360399 )
Change subject: Make MalformedTitleException errorMessage non-null
......................................................................
Make MalformedTitleException errorMessage non-null
A null $errorMessage constructor argument has not been supported since
I43d988602b, since wfMessage (via the Message constructor) throws an
exception if the message key is null. It follows that getErrorMessage()
can never return null.
Change-Id: I2cbf4909e7237b0a91d100cc5478fb4cfee1d748
---
M includes/title/MalformedTitleException.php
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/99/360399/1
diff --git a/includes/title/MalformedTitleException.php
b/includes/title/MalformedTitleException.php
index 2dddac5..213343f 100644
--- a/includes/title/MalformedTitleException.php
+++ b/includes/title/MalformedTitleException.php
@@ -34,7 +34,7 @@
* $titleText will be appended if it's not null. (since MW 1.26)
*/
public function __construct(
- $errorMessage = null, $titleText = null,
$errorMessageParameters = []
+ $errorMessage, $titleText = null, $errorMessageParameters = []
) {
$this->errorMessage = $errorMessage;
$this->titleText = $titleText;
@@ -59,7 +59,7 @@
/**
* @since 1.26
- * @return string|null
+ * @return string
*/
public function getErrorMessage() {
return $this->errorMessage;
--
To view, visit https://gerrit.wikimedia.org/r/360399
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cbf4909e7237b0a91d100cc5478fb4cfee1d748
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
