jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/360696 )
Change subject: skinStyles can now be registered via ResourceModuleSkinStyles
......................................................................
skinStyles can now be registered via ResourceModuleSkinStyles
ResourceModuleSkinStyles is now compatible with
MFResourceLoaderParsedMessageModule
Change-Id: Ia6ebdacf7b37b8ed383161d9ab7846a199500f77
Depends-On: I35a12a451bf2695818702df1bbd1708173a3f9ce
---
M extension.json
1 file changed, 6 insertions(+), 7 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index ac6c493..92f64b8 100644
--- a/extension.json
+++ b/extension.json
@@ -692,9 +692,6 @@
"mobile.loggingSchemas.mobileWebSearch",
"mobile.search.images"
],
- "skinStyles": {
- "minerva":
"skinStyles/mobile.search/SearchOverlay.less"
- },
"styles": [
"resources/mobile.search/SearchOverlay.less"
],
@@ -1000,9 +997,6 @@
"mediawiki.storage",
"mobile.startup"
],
- "skinStyles": {
- "minerva":
"skinStyles/mobile.languages.structured/LanguageOverlay.less"
- },
"scripts": [
"resources/mobile.languages.structured/util.js",
"resources/mobile.languages.structured/LanguageOverlay.js"
@@ -1628,9 +1622,14 @@
"@note1": "ResourceModuleSkinStyles must only contain customizations
for 'minerva'.",
"@note2": "For other skins, just use 'skinStyles' in module
definition.",
"@note3": "Otherwise their own customizations are overridden.
(T167216)",
- "@note5": "Do not use it for modules which non-ResourceLoaderFileModule
classes (T167478).",
"ResourceModuleSkinStyles": {
"minerva": {
+ "mobile.search": {
+ "minerva":
"skinStyles/mobile.search/SearchOverlay.less"
+ },
+ "mobile.languages.structured": {
+ "minerva":
"skinStyles/mobile.languages.structured/LanguageOverlay.less"
+ },
"mobile.startup": [
"skinStyles/mobile.startup/toast.less",
"skinStyles/mobile.startup/Overlay.less"
--
To view, visit https://gerrit.wikimedia.org/r/360696
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6ebdacf7b37b8ed383161d9ab7846a199500f77
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
